Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to include fast fill logic #363

Merged

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Apr 27, 2020

This #318 introduced a PrecreatingMode which actually let the CVO to push the clusterOperator in manifests.
This changes previous behaviour and enables a new pattern for individual operators to set related objects into the clusterOperator defined in manifests/ openshift/cluster-kube-apiserver-operator#833
openshift/cluster-etcd-operator#312
openshift/cluster-kube-controller-manager-operator#398

This openshift#318 introduced a PrecreatingMode which actually let the CVO to push the clusterOperator in manifests.
This enables a new pattern for individual operators to set related objects into the clusterOperator defined in manifests/ openshift/cluster-kube-apiserver-operator#833
openshift/cluster-etcd-operator#312
openshift/cluster-kube-controller-manager-operator#398
@enxebre
Copy link
Member Author

enxebre commented Apr 27, 2020

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@smarterclayton smarterclayton added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit fa452c2 into openshift:master Apr 27, 2020
wking added a commit to wking/openshift-enhancements that referenced this pull request Sep 22, 2022
…oesn't create

The "resources to create" wording was presumably a typo back in
openshift/cluster-version-operator@a2ded12726 (Update readme to
include fast fill logic, 2020-04-27,
openshift/cluster-version-operator#363), and we pulled it over here
with f8a9ee5 (straight move of cluster-version-operator docs
folder, 2021-07-23, openshift#695).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants