New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1978376: pkg/cvo/upgradeable: Enable admin-ack logic #645
Bug 1978376: pkg/cvo/upgradeable: Enable admin-ack logic #645
Conversation
@wking: An error was encountered querying GitHub for users with public email (jialiu@redhat.com) for bug 1978376 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
519b466 (Bug 1978376: Add admin ack Upgradeable condition gate, 2021-07-27, openshift#633) had these commented out, because 4.9 has no built-in acks. But with the code commented out, it's hard to verify that the logic works in 4.9 before backporting to 4.8 [1]. Enabling these checks should be a no-op outside of verification, because admins are unlikely to inject additional keys in the openshift-config-managed namespace's admin-gates ConfigMap. And it allows us to verify the logic in 4.9 and cook there with live code before approving the 4.8 backports. It's also one less thing we might forget before enabling new admin acks in future versions, like 4.10 or later. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1978376#c19
097097d
to
5b5db7d
Compare
/bugzilla refresh |
@wking: This pull request references Bugzilla bug 1978376, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-agnostic |
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: All pull requests linked via external trackers have merged:
Bugzilla bug 1978376 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
519b466 (#633) had these commented out, because 4.9 has no built-in acks. But with the code commented out, it's hard to verify that the logic works in 4.9 before backporting to 4.8. Enabling these checks should be a no-op outside of verification, because admins are unlikely to inject additional keys in the
openshift-config-managed
namespace'sadmin-gates
ConfigMap. And it allows us to verify the logic in 4.9 and cook there with live code before approving the 4.8 backports. It's also one less thing we might forget before enabling new admin acks in future versions, like 4.10 or later.