New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2011896: pkg/cvo/upgradeable: Include messages for multiple-reason Upgradeable=False #670
Bug 2011896: pkg/cvo/upgradeable: Include messages for multiple-reason Upgradeable=False #670
Conversation
9202c28
to
97adc79
Compare
Looks good /test unit |
97adc79
to
db432ec
Compare
@wking: This pull request references Bugzilla bug 2011896, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…=False Because: Upgradeable=False Reason: MultipleReasons Message: Cluster cannot be upgraded between minor versions for multiple reasons: AdminAckRequired,IncompatibleOperatorsInstalled doesn't include all the useful information needed to resolve those issues. This pivots to using the same approach we use today when aggregating multiple Upgradeable=False ClusterOperators. Also shift the patch-blocking overrides check in front of the other minor blocking checks. It's more important (because it blocks more targets), and it also will not included a nested sub-list (which might be confusing, because today I'm not adding indents or any such markers to make it easy to distinguish levels in a nested list hierarchy).
db432ec
to
9a1e58c
Compare
Two unrelated pod-sandbox errors: /retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unrelated sandbox issue: /override ci/prow/e2e-agnostic-upgrade |
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2011896 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because:
doesn't include all the useful information needed to resolve those issues. This pivots to using the same approach we use today when aggregating multiple
Upgradeable=False
ClusterOperators.