Skip to content

Bug 1764224: Use extension manifests from openshift/api #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2019
Merged

Bug 1764224: Use extension manifests from openshift/api #316

merged 4 commits into from
Oct 23, 2019

Conversation

@benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Oct 16, 2019 •
edited
Loading

3rd pass on this PR today :)

We can just copy the generated CRDs from openshift/api in /vendor in our Dockerfiles.

TODO as follow-up:

/cc @spadgett @jhadvig

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 16, 2019
@benjaminapetersen benjaminapetersen mentioned this pull request Oct 16, 2019
Closed
3 tasks
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2019

/retest

@benjaminapetersen
Copy link
Contributor Author

/hold

Using #314 since the revert PR openshift/cluster-config-operator#103 is no longer held.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@benjaminapetersen
Copy link
Contributor Author

/close

short term. this is long term fix.

@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: Closed this PR.

In response to this:

/close

short term. this is long term fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benjaminapetersen benjaminapetersen mentioned this pull request Oct 17, 2019
Merged
3 tasks
@benjaminapetersen benjaminapetersen changed the title Crd/generated/from openshift api Use extension manifests from openshift/api Oct 17, 2019
@benjaminapetersen benjaminapetersen force-pushed the crd/generated/from-openshift-api branch from 53b3113 to dd123ff Compare October 17, 2019 19:05
spadgett
spadgett approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@benjaminapetersen
Copy link
Contributor Author

/retest

@benjaminapetersen
Copy link
Contributor Author

/retest

could not wait for build: the build console-operator failed after 2m18s with reason DockerBuildFailed: Docker build strategy has failed.

@benjaminapetersen
Copy link
Contributor Author 

github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".CLIDownloadLink in field value
pkg/console/controllers/clidownloads/controller_test.go:87:6: cannot use []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".Link literal (type []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".Link) as type []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".CLIDownloadLink in field value
# github.com/openshift/console-operator/pkg/console/controllers/clidownloads
pkg/console/controllers/clidownloads/controller.go:186:4: cannot use links (type []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".Link) as type []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".CLIDownloadLink in field value
pkg/console/controllers/clidownloads/controller.go:202:4: cannot use []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".Link literal (type []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".Link) as type []"github.com/openshift/console-operator/vendor/github.com/openshift/api/console/v1".CLIDownloadLink in field value
[FATAL] FAILURE: go vet failed!
[ERROR] hack/verify-govet.sh exited with code 1 after 00h 00m 39s
[INFO] No compiled `import-verifier` binary was found. Attempting to build one using:
[INFO]   $ hack/build-go.sh tools/import-verifier
++ Building go targets for linux/amd64: tools/import-verifier
[INFO] hack/build-go.sh exited with code 0 after 00h 00m 03s
Running hack/verify-imports.sh:17: executing 'import-verifier /go/src/github.com/openshift/console-operator/hack/import-restrictions.json' expecting success...
SUCCESS after 0.023s: hack/verify-imports.sh:17: executing 'import-verifier /go/src/github.com/openshift/console-operator/hack/import-restrictions.json' expecting success
[INFO] hack/verify-imports.sh exited with code 0 after 00h 00m 04s
make: *** [verify] Error 1

@jhadvig same test issue.

@benjaminapetersen
Copy link
Contributor Author

/retest

@benjaminapetersen benjaminapetersen mentioned this pull request Oct 22, 2019
Closed
@benjaminapetersen benjaminapetersen force-pushed the crd/generated/from-openshift-api branch from dd123ff to eb1545c Compare October 22, 2019 16:20
@benjaminapetersen
Copy link
Contributor Author

Bumped deps & rebased.
Should pick up @jhadvig's changes to validation.

@spadgett spadgett changed the title Use extension manifests from openshift/api Bug 1764224: Use extension manifests from openshift/api Oct 22, 2019
@benjaminapetersen
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 22, 2019
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1764224, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1764224: Use extension manifests from openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 22, 2019
@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@benjaminapetersen
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@benjaminapetersen benjaminapetersen force-pushed the crd/generated/from-openshift-api branch from 2e57486 to 5454d46 Compare October 22, 2019 17:43
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@benjaminapetersen
Copy link
Contributor Author

/hold remove

@spadgett
Copy link
Member

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 22, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Member

jhadvig commented Oct 23, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2019 •
edited
Loading

@benjaminapetersen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade dd123ff link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminapetersen
Copy link
Contributor Author

/retest

level=fatal msg="failed to initialize the cluster: Cluster operator console has not yet reported success"

Hmm. that one is us. We got a new flake?

@openshift-merge-robot openshift-merge-robot merged commit cfd7d0f into openshift:master Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1764224 has been moved to the MODIFIED state.

In response to this:

Bug 1764224: Use extension manifests from openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig jhadvig approved these changes

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@benjaminapetersen @deads2k @openshift-ci-robot @spadgett @openshift-bot @jhadvig @openshift-merge-robot