New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Allow console service account to read HelmChartRepository CR" #456
Conversation
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp |
/hold |
Bug is Jira: https://issues.redhat.com/browse/APPSVC-655 Counterpart console PR: openshift/console#6318 |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Reverts #455
Reverting this PR based on #455 (comment). The approach does not look right to me. We can reapply if it's really needed, but we need to see the corresponding console PR to properly review. It would be better not to grant the console service account this authority if we can avoid it, and the approach is inconsistent with how the console handles other cluster config.
/assign @jhadvig
cc @pedjak