Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1894216: Improve OpenShift Console availability #483

Merged
merged 1 commit into from Dec 15, 2020

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Nov 23, 2020

Based on the bug description, we should avoid several minute outage in case of node failure pods are rescheduled to a healthy zone. For that reason we should use RequiredDuringSchedulingIgnoredDuringExecution, due to the docs.
Also 3 console replicas are recommended, although not sure if that's necessary.

/assign @spadgett

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 23, 2020
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Bugzilla bug 1894216, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1894216: Improve OpenShift Console availability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 23, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@jhadvig
Copy link
Member Author

jhadvig commented Nov 23, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@jhadvig: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-agnostic-upgrade
  • /test e2e-aws-console
  • /test e2e-aws-operator
  • /test e2e-gcp
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/test retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member Author

jhadvig commented Nov 23, 2020

/retest

1 similar comment
@jhadvig
Copy link
Member Author

jhadvig commented Nov 23, 2020

/retest

@spadgett
Copy link
Member

@jhadvig It doesn't look like this adds zone anti-affinity requested in the Bugzilla.

@smarterclayton @derekwaynecarr Any recommendations on what to set here? See https://bugzilla.redhat.com/show_bug.cgi?id=1894216

@jhadvig jhadvig requested a review from csrwng December 15, 2020 14:16
@csrwng
Copy link
Contributor

csrwng commented Dec 15, 2020

lgtm

@csrwng
Copy link
Contributor

csrwng commented Dec 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c4f32c5 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@jhadvig: All pull requests linked via external trackers have merged:

Bugzilla bug 1894216 has been moved to the MODIFIED state.

In response to this:

Bug 1894216: Improve OpenShift Console availability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants