Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-3005: Provide alias for dynamic plugin's proxy #613

Merged
merged 2 commits into from Jan 13, 2022

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Nov 24, 2021

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
go.mod Outdated
@@ -26,6 +26,6 @@ require (
)

replace (
github.com/openshift/api => github.com/jhadvig/api v0.0.0-20211101154927-473eacc76bdf
github.com/openshift/api => github.com/jhadvig/api v0.0.0-20211123072135-f1f89fe5508f
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once openshift/api#1067 will get merged will update both pkgs... api && client-go

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2022
@jhadvig
Copy link
Member Author

jhadvig commented Jan 10, 2022

QE Approver:

/assign @yapei
Docs Approver:

/assign @opayne1
PX Approver:

/assign @RickJWagner
Approver:

/assign @spadgett

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Changes LGTM, just need to wait for the API PR to merge

@RickJWagner
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 10, 2022
@RickJWagner RickJWagner removed their assignment Jan 10, 2022
@opayne1
Copy link

opayne1 commented Jan 10, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 10, 2022
@yapei
Copy link
Contributor

yapei commented Jan 12, 2022

  1. deploy https://raw.githubusercontent.com/yapei/console/780ef7276e1bda53fd94c419d985e43931badf90/dynamic-demo-plugin/oc-manifest.yaml(replace image with quay.io/yapei/console-demo-plugin-separator-story:latest) which includes ConsolePlugin with following spec
apiVersion: console.openshift.io/v1alpha1
kind: ConsolePlugin
metadata:
  name: console-demo-plugin
spec:
  displayName: 'OpenShift Console Demo Plugin'
  service:
    name: console-demo-plugin
    namespace: console-demo-plugin
    port: 9001
    basePath: '/'
  proxy:
  - type: Service
    alias: demoplugin
    service:
        name: thanos-querier
        namespace: openshift-monitoring
        port: 9091
        authorize: true

$ oc apply -f oc-manifest.yaml
2. enable console-demo-plugin and visit /test-proxy-service URL, response of request /api/proxy/console-demo-plugin/demoplugin/api/v1/rules is displayed on the page
Screen Shot 2022-01-11 at 4 48 21 PM

@yapei
Copy link
Contributor

yapei commented Jan 12, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 12, 2022
@jhadvig
Copy link
Member Author

jhadvig commented Jan 12, 2022

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Jan 12, 2022

@spadgett go.mod update... we should be ready to merge

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants