New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-3005: Provide alias for dynamic plugin's proxy #613
Conversation
go.mod
Outdated
@@ -26,6 +26,6 @@ require ( | |||
) | |||
|
|||
replace ( | |||
github.com/openshift/api => github.com/jhadvig/api v0.0.0-20211101154927-473eacc76bdf | |||
github.com/openshift/api => github.com/jhadvig/api v0.0.0-20211123072135-f1f89fe5508f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once openshift/api#1067 will get merged will update both pkgs... api && client-go
QE Approver: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Changes LGTM, just need to wait for the API PR to merge
/label px-approved |
/label docs-approved |
$ oc apply -f oc-manifest.yaml |
/label qe-approved |
/retest |
@spadgett |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@jhadvig: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Story: https://issues.redhat.com/browse/CONSOLE-3005
Changes are based on the API change PR
/assign @christianvogt @spadgett