Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1961391: Textual updates follow-up #10008

Merged
merged 1 commit into from Sep 9, 2021
Merged

Bug 1961391: Textual updates follow-up #10008

merged 1 commit into from Sep 9, 2021

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Sep 7, 2021

This PR:

  • Covers the corner case where there are a lot of storage classes.
  • Removes the un-used commaSeparatedString method.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@rexagod: This pull request references Bugzilla bug 1961391, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1961391: Textual updates follow-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rexagod
Copy link
Member Author

rexagod commented Sep 7, 2021

Follows up on #9333

@rexagod
Copy link
Member Author

rexagod commented Sep 7, 2021

/cc @afreen23

@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Sep 7, 2021
@rexagod
Copy link
Member Author

rexagod commented Sep 7, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@rexagod: This pull request references Bugzilla bug 1961391, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rexagod
Bug 1961391: Textual updates follow-up
16b1d26 
This PR:
* Covers the corner case where there are a lot of storage classes.
* Removes the un-used `commaSeparatedString` method.
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Sep 7, 2021
@rexagod
Copy link
Member Author

rexagod commented Sep 7, 2021

/test ceph-storage-plugin

afreen23
afreen23 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@rexagod
Copy link
Member Author

rexagod commented Sep 8, 2021

/test ceph-storage-plugin

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rexagod
Copy link
Member Author

rexagod commented Sep 8, 2021

/hold
Need to fix a test case.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2021
@rexagod
Copy link
Member Author

rexagod commented Sep 8, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2021
@rexagod
Copy link
Member Author

rexagod commented Sep 8, 2021

/test ceph-storage-plugin

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d28f08a into openshift:master Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@rexagod: All pull requests linked via external trackers have merged:

Bugzilla bug 1961391 has been moved to the MODIFIED state.

In response to this:

Bug 1961391: Textual updates follow-up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 approved these changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rexagod @openshift-bot @afreen23 @spadgett @openshift-merge-robot