Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1989843: 'More' and 'Show Less' chips are not translated #10091

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented Sep 16, 2021

Fixes the missing translations for the show x More and Show Less
chips on the pods, roles, nodes, etc list pages.

Patternfly bump is necessary to pick up @rebeccaalpert changes in Patternfly:
patternfly/patternfly-react#6138

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1989843

Screen Shot 2021-09-16 at 2 15 56 PM

Screen Shot 2021-09-16 at 2 16 08 PM

Fixes the missing translations for the show `x` More and Show Less
chips on the pods, roles, nodes, etc list pages.

Patternfly bump is necessary to pick up @rebeccaalpert changes in Patternfly:
patternfly/patternfly-react#6138

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1989843
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@florkbr: This pull request references Bugzilla bug 1989843, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989843: 'More' and 'Show Less' chips are not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 16, 2021
@florkbr
Copy link
Contributor Author

florkbr commented Sep 16, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@florkbr: This pull request references Bugzilla bug 1989843, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 16, 2021
@openshift-ci openshift-ci bot requested a review from yapei September 16, 2021 19:06
@dtaylor113
Copy link
Contributor

dtaylor113 commented Sep 16, 2021

Hi @florkbr, PR up with update to latest patternfly versions. Bumps "@patternfly/react-core" to "4.157.2" which was the latest PF released. Have they not released "@patternfly/react-core": "4.148.1", yet?

@dtaylor113
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should there be updated i18n json files which have new keys: public <1> more, public-Show less, etc..? Need to run yarn i18n?

@florkbr
Copy link
Contributor Author

florkbr commented Sep 16, 2021

@dtaylor113 these strings already exist in the public.json strings, so no string changes are necessary.

Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@florkbr
Copy link
Contributor Author

florkbr commented Sep 16, 2021

Pod didn't start :(

/retest required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@florkbr: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test analyze
  • /test backend
  • /test ceph-storage-plugin
  • /test e2e-gcp-console
  • /test frontend
  • /test images
  • /test kubevirt-plugin

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images

In response to this:

Pod didn't start :(

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, florkbr, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@florkbr
Copy link
Contributor Author

florkbr commented Sep 16, 2021

/retest-required

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8aaaeb5 into openshift:master Sep 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@florkbr: All pull requests linked via external trackers have merged:

Bugzilla bug 1989843 has been moved to the MODIFIED state.

In response to this:

Bug 1989843: 'More' and 'Show Less' chips are not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants