New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1989843: 'More' and 'Show Less' chips are not translated #10091
Bug 1989843: 'More' and 'Show Less' chips are not translated #10091
Conversation
Fixes the missing translations for the show `x` More and Show Less chips on the pods, roles, nodes, etc list pages. Patternfly bump is necessary to pick up @rebeccaalpert changes in Patternfly: patternfly/patternfly-react#6138 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1989843
@florkbr: This pull request references Bugzilla bug 1989843, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@florkbr: This pull request references Bugzilla bug 1989843, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @florkbr, PR up with update to latest patternfly versions. Bumps "@patternfly/react-core" to "4.157.2" which was the latest PF released. Have they not released "@patternfly/react-core": "4.148.1", yet? |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, should there be updated i18n json files which have new keys: public <1> more
, public-Show less
, etc..? Need to run yarn i18n
?
@dtaylor113 these strings already exist in the public.json strings, so no string changes are necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Pod didn't start :( /retest required |
@florkbr: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, florkbr, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@florkbr: All pull requests linked via external trackers have merged: Bugzilla bug 1989843 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes the missing translations for the show
x
More and Show Lesschips on the pods, roles, nodes, etc list pages.
Patternfly bump is necessary to pick up @rebeccaalpert changes in Patternfly:
patternfly/patternfly-react#6138
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1989843