New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2001577: Quick search placeholder is not displayed properly when the search string is removed #10104
Bug 2001577: Quick search placeholder is not displayed properly when the search string is removed #10104
Conversation
@yozaam: This pull request references Bugzilla bug 2001577, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yozaam: This pull request references Bugzilla bug 2001577, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, karthikjeeyar, yozaam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yozaam: All pull requests linked via external trackers have merged: Bugzilla bug 2001577 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2001577
https://issues.redhat.com/browse/OCPBUGSM-34451
Analysis / Root cause:
When the size of the search text was smaller than the placeholder & we would clear it completely, then the input field did not have enough size to fit the entire placeholder
Solution Description:
Never let the size be smaller than placeholder size
Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
Browser conformance: