Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netobserv-35 : network policy creation form - UX updates #10105

Conversation

OlivierCazade
Copy link
Contributor

  • In Ingress / Egress field groups, the description sentence is now part of the Field group header
  • In rule definition, the ports section is now empty, similar to how selectors work.
  • Changed some wording to comply with last provided mockups

JIRA issue : https://issues.redhat.com/browse/NETOBSERV-35

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 20, 2021
@jotak
Copy link
Contributor

jotak commented Sep 20, 2021

/cc

@openshift-ci openshift-ci bot requested a review from jotak September 20, 2021 11:27
<PlusCircleIcon className="co-icon-space-r" />
{t('public~Add port')}
</Button>
<FormFieldGroup
Copy link
Contributor

@jotak jotak Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen with Andrew, we should get rid of this heading "accessible ports", it's redundant with the "port" title

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Sep 20, 2021
Copy link
Contributor

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jotak
Copy link
Contributor

jotak commented Sep 22, 2021

/cc @jechen0648

@jechen0648
Copy link

I added one comment about the description for CIDR in https://issues.redhat.com/browse/NETOBSERV-35, everything else looks good to me.

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 28, 2021
@OlivierCazade OlivierCazade force-pushed the netobserv-35-network-policy-form branch 2 times, most recently from df238f8 to 9101da0 Compare September 29, 2021 13:24
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I will defer to @jotak on the final lgtm.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@jechen0648
Copy link

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2021
In Ingress / Egress field groups, the description sentence should be part of the Field group header

JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
In rule definition, the ports section should not show any input when empty (similar to how selectors work).

JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
This changes are made to comply with the last provided mockups.

JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
@OlivierCazade OlivierCazade force-pushed the netobserv-35-network-policy-form branch from 9101da0 to b25da19 Compare October 1, 2021 09:47
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 1, 2021
@jotak
Copy link
Contributor

jotak commented Oct 4, 2021

/lgtm

/label qe-approved

(previously approved by @jechen0648 )

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 4, 2021
@jotak
Copy link
Contributor

jotak commented Oct 4, 2021

/label docs-approved
Small UX changes, no docs change ; cc @nalhadef

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 4, 2021
@jotak
Copy link
Contributor

jotak commented Oct 4, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jechen0648, jotak, OlivierCazade, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f2ed4aa into openshift:master Oct 4, 2021
@spadgett spadgett added this to the v4.10 milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants