New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netobserv-35 : network policy creation form - UX updates #10105
Netobserv-35 : network policy creation form - UX updates #10105
Conversation
/cc |
frontend/packages/console-app/src/components/network-policies/network-policy-ports.tsx
Show resolved
Hide resolved
<PlusCircleIcon className="co-icon-space-r" /> | ||
{t('public~Add port')} | ||
</Button> | ||
<FormFieldGroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen with Andrew, we should get rid of this heading "accessible ports", it's redundant with the "port" title
035ba22
to
190a7c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/cc @jechen0648 |
I added one comment about the description for CIDR in https://issues.redhat.com/browse/NETOBSERV-35, everything else looks good to me. |
/label px-approved |
df238f8
to
9101da0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I will defer to @jotak on the final lgtm.
/lgtm |
frontend/packages/console-app/src/components/network-policies/network-policy-form.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/network-policies/network-policy-form.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/network-policies/network-policy-peer-ipblock.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/network-policies/network-policy-ports.tsx
Outdated
Show resolved
Hide resolved
In Ingress / Egress field groups, the description sentence should be part of the Field group header JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
In rule definition, the ports section should not show any input when empty (similar to how selectors work). JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
This changes are made to comply with the last provided mockups. JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
This helper was missing. JIRA issue: https://issues.redhat.com/browse/NETOBSERV-35
9101da0
to
b25da19
Compare
/label qe-approved (previously approved by @jechen0648 ) |
/label docs-approved |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jechen0648, jotak, OlivierCazade, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA issue : https://issues.redhat.com/browse/NETOBSERV-35