New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1998241: Support OB/C pages for Ceph Standalone Mode if RGW is present #10108

Merged

openshift-merge-robot merged 1 commit into openshift:master from bipuladh:fix-objects-page

Dec 29, 2021

Contributor

bipuladh commented Sep 21, 2021

Contributor

openshift-ci bot commented Sep 21, 2021

@bipuladh: This pull request references Bugzilla bug 1998241, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1998241: Support OB/C pages for Ceph Standalone Mode if RGW is present

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium bugzilla/valid-bug labels

Contributor Author

bipuladh commented Sep 21, 2021

/assign @SanjalKatiyar

openshift-ci bot assigned SanjalKatiyar

openshift-ci bot requested review from cloudbehl and shyRozen

September 21, 2021 05:35

openshift-ci bot added component/ceph approved labels

SanjalKatiyar reviewed

View reviewed changes

frontend/packages/ceph-storage-plugin/src/plugin.ts Outdated Show resolved Hide resolved

bipuladh force-pushed the fix-objects-page branch from 5e6250c to a2c1e40 Compare

September 21, 2021 06:24

bipuladh requested a review from SanjalKatiyar

September 21, 2021 06:54

SanjalKatiyar reviewed

View reviewed changes

frontend/packages/ceph-storage-plugin/console-extensions.json Outdated

@@ @@ -79,6 +79,24 @@ @@
                     "required": ["MCG"]
                   }
                 },
+                // Activates when RGW is present without MCG

Contributor

SanjalKatiyar Sep 21, 2021

Comments are not permitted in JSON

Contributor Author

bipuladh Dec 21, 2021

We are using JSONC.

bipuladh force-pushed the fix-objects-page branch 3 times, most recently from 9db7fdf to 7ecebad Compare

September 23, 2021 09:06

SanjalKatiyar reviewed

View reviewed changes

frontend/packages/ceph-storage-plugin/src/plugin.ts Outdated

@@ @@ -136,7 +137,7 @@ const plugin: Plugin<ConsumedExtensions> = [ @@
                     detect: detectComponents,
                   },
                   flags: {
-                    required: [OCS_FLAG],
+                    required: [ODF_MODEL_FLAG],

Contributor

SanjalKatiyar Sep 23, 2021

Can we use OCS_MODEL_FLAG in case someone is using OCS 4.8 ??
Or it is not allowed to use OCS 4.8 on OCP 4.10 ??

Contributor Author

bipuladh Dec 21, 2021

OCP 4.10 will not support OCS 4.8

afreen23 suggested changes

View reviewed changes

frontend/packages/ceph-storage-plugin/console-extensions.json

Comment on lines +95 to +91

+                  "flags": {
+                    "required": ["RGW"],
+                    "disallowed": ["MCG"]

Contributor

afreen23 Nov 30, 2021

cant we do following instead of adding in a new extension ?

Suggested change

      
                "flags": {
          
                  "required": ["RGW"],
          
                  "disallowed": ["MCG"]
          
                "flags": {
          
                  "required": ["RGW", "MCG"],

Contributor Author

bipuladh Dec 21, 2021

Required flags use a AND logic. So to create an OR logic we need to a new extension.

bipuladh requested review from SanjalKatiyar and afreen23

December 21, 2021 05:43

bipuladh force-pushed the fix-objects-page branch from 7ecebad to b7a5514 Compare

December 21, 2021 05:44

Contributor Author

bipuladh commented Dec 21, 2021

/retest

SanjalKatiyar approved these changes

View reviewed changes

Contributor

SanjalKatiyar left a comment

/lgtm

openshift-ci bot added the lgtm label

Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 21, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments

Contributor

openshift-bot commented Dec 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 22, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

bipuladh commented Dec 23, 2021

/hold
Tests are failing a lot. Investigating it.

openshift-ci bot added the do-not-merge/hold label

bipuladh force-pushed the fix-objects-page branch from b7a5514 to 0fe1e9f Compare

December 27, 2021 09:27

openshift-ci bot removed the lgtm label

Contributor Author

bipuladh commented Dec 27, 2021

/test ceph-storage-plugin

Contributor

openshift-ci bot commented Dec 27, 2021 •

edited

@bipuladh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp	`7ecebad`	link	true	`/test e2e-gcp`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


          Support OB/C pages for Ceph Standalone Mode if RGW is present

bipuladh force-pushed the fix-objects-page branch from 0fe1e9f to 2341615 Compare

December 28, 2021 05:35

Contributor Author

bipuladh commented Dec 29, 2021

/hold cancel
Tests are passing

openshift-ci bot removed the do-not-merge/hold label

Contributor

SanjalKatiyar commented Dec 29, 2021

/lgtm

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Dec 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot merged commit cbc8b87 into openshift:master

Contributor

openshift-ci bot commented Dec 29, 2021

@bipuladh: All pull requests linked via external trackers have merged:

openshift/console#10108

Bugzilla bug 1998241 has been moved to the MODIFIED state.

In response to this:

Bug 1998241: Support OB/C pages for Ceph Standalone Mode if RGW is present

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Author

bipuladh commented Jun 7, 2022

/bugzilla refresh

Contributor

openshift-ci bot commented Jun 7, 2022

@bipuladh: All pull requests linked via external trackers have merged:

openshift/console#10108

Bugzilla bug 1998241 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment