New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2014248: i18n several missed files #10244
Bug 2014248: i18n several missed files #10244
Conversation
@rebeccaalpert: This pull request references Bugzilla bug 2014248, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rebeccaalpert: This pull request references Bugzilla bug 2014248, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rebeccaalpert Most of the code here is being removed, so we purposely skipped it :/ See #9870 |
Oh nice! I wasn't aware of Maude's PR. I'll go through and remove the files she's targeting and see if I have anything left to commit. |
I noticed a bunch of loading box text and error messages weren't done while going through Krishna's spreadsheet (it was stuff he didn't specifically call out), so I'll fold that into this PR. |
b6e3ca8
to
0e39392
Compare
Backed out changes for the following (work is in progress in other PRs to i18n or delete these files):
|
0e39392
to
bc6637d
Compare
bc6637d
to
dd3f86a
Compare
/test e2e-gcp-console |
Test failure:
|
frontend/public/components/error.tsx
Outdated
'There was an authentication error with the system. Please try again or contact support.', | ||
}, | ||
}; | ||
const getMessage = (type, id) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets type the input and output here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set! It looks like these are usually strings, but I'm not really familiar with this code. Let me know if there's some instance where it's something else.
53f4bcc
to
ff119c0
Compare
/test e2e-gcp-console |
ff119c0
to
21905d9
Compare
frontend/public/components/error.tsx
Outdated
<div className="co-copy-to-clipboard__stacktrace-width-height"> | ||
<CopyToClipboard value={props.stack.trim()} /> | ||
<div className="form-group"> | ||
<label htmlFor="componentTrace">{t('public~Component trace: ')}</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebeccaalpert Sorry, my last comment also applies to this message and the one just below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set @spadgett.
Several files appear to have been missed or only partially done. I did the rest. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2014248
21905d9
to
08cc7fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Putting on hold so I can take a look at the test history after my meeting. |
Tests look ok? |
@rebeccaalpert: All pull requests linked via external trackers have merged: Bugzilla bug 2014248 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Several files appear to have been missed or only partially done. I did the rest.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2014248.