New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2016453: Complete i18n for GaugeChart defaults #10317
Bug 2016453: Complete i18n for GaugeChart defaults #10317
Conversation
@kdoberst: This pull request references Bugzilla bug 2016453, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rebeccaalpert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kim! I left a couple of comments - i18next.t can be a pain, so I want to make sure we won't run into issues.
b3e6cfd
to
78a9c7e
Compare
Also removed the use i18next for the useTranslation hook
78a9c7e
to
b807fc3
Compare
@spadgett @rebeccaalpert Make changes to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thanks for making those changes, Kim.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kdoberst, rebeccaalpert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kdoberst: All pull requests linked via external trackers have merged: Bugzilla bug 2016453 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses Bug 2016453
Ensures that all the default text for the gauge chart are translated.