Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2016453: Complete i18n for GaugeChart defaults #10317

Conversation

kdoberst
Copy link
Contributor

Addresses Bug 2016453

Ensures that all the default text for the gauge chart are translated.

@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2021

@kdoberst: This pull request references Bugzilla bug 2016453, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2016453: Complete i18n for GaugeChart defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 25, 2021
@openshift-ci openshift-ci bot requested a review from yapei October 25, 2021 19:11
@kdoberst
Copy link
Contributor Author

/assign @rebeccaalpert

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2021
Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kim! I left a couple of comments - i18next.t can be a pain, so I want to make sure we won't run into issues.

frontend/public/components/graphs/gauge.tsx Outdated Show resolved Hide resolved
frontend/public/components/graphs/gauge.tsx Outdated Show resolved Hide resolved
@kdoberst kdoberst force-pushed the Bug-2016453-Complete-i18n-for-GaugeChart-defaults branch from b3e6cfd to 78a9c7e Compare October 25, 2021 21:28
Also removed the use i18next for the useTranslation hook
@kdoberst kdoberst force-pushed the Bug-2016453-Complete-i18n-for-GaugeChart-defaults branch from 78a9c7e to b807fc3 Compare October 25, 2021 21:32
@kdoberst
Copy link
Contributor Author

@spadgett @rebeccaalpert Make changes to use the useTranslation hook. This meant I needed to pull some of the default values out of the params into the body of the function. Please take a look.

Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for making those changes, Kim.

@rebeccaalpert rebeccaalpert added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst, rebeccaalpert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 98ebfb0 into openshift:master Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

@kdoberst: All pull requests linked via external trackers have merged:

Bugzilla bug 2016453 has been moved to the MODIFIED state.

In response to this:

Bug 2016453: Complete i18n for GaugeChart defaults

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants