New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2015806: Fix resource metrics 403 errors for project admin users #10344
Conversation
- Add namespace prop to QueryBrowser in ResourceMetricsDashboardCard component, which causes all queries to be run as namespace-scoped thanos tenancy requests. - Remove namespace from all PromQL queries defined in `frontend/packages/console-shared/src/promql/resource-metrics.ts`. These queries will always be run as namespace-scoped tenancy endpoint requests, so including the namespace in the PromQL query is redundant. - Adjust dev console top workload metrics "Recieve bandwidth" PromQL query to use `namespace=` rather than `namespace=~`. This was causing a `400: Bad Request` on tenancy requests witn `namespace` in the URL query parameters.
@TheRealJon: This pull request references Bugzilla bug 2015806, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* on (namespace,pod) group_left(workload,workload_type) namespace_workload_pod:kube_pod_owner:relabel{ | ||
namespace=~'<%= namespace %>', workload=~'<%= workloadName %>', workload_type='<%= workloadType %>'}) by (pod)`, | ||
namespace='<%= namespace %>', workload=~'<%= workloadName %>', workload_type='<%= workloadType %>'}) by (pod)`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should also be =
rather than =~
for workload
, although I realize that's not directly related to the bug this PR is fixing.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@kyoto: This pull request references Bugzilla bug 2015806, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@TheRealJon: All pull requests linked via external trackers have merged: Bugzilla bug 2015806 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.9 |
@TheRealJon: new pull request created: #10396 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/console-shared/src/promql/resource-metrics.ts
. These queries will always be run as namespace-scoped tenancy endpoint requests, so including the namespace in the PromQL query is redundant.namespace=
rather thannamespace=~
. This was causing a400: Bad Request
when requests hadnamespace
in the URL query parameters.