Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2015806: Fix resource metrics 403 errors for project admin users #10344

Merged
merged 1 commit into from Oct 28, 2021

Conversation

TheRealJon
Copy link
Member

  • Add namespace prop to QueryBrowser in ResourceMetricsDashboardCard component, which causes all queries to be run as namespace-scoped requests to the thanos tenancy endpoint.
  • Remove namespace from all PromQL queries defined in frontend/packages/console-shared/src/promql/resource-metrics.ts. These queries will always be run as namespace-scoped tenancy endpoint requests, so including the namespace in the PromQL query is redundant.
  • Adjust dev console top workload metrics "Recieve bandwidth" PromQL query to use namespace= rather than namespace=~. This was causing a 400: Bad Request when requests had namespace in the URL query parameters.

- Add namespace prop to QueryBrowser in ResourceMetricsDashboardCard component, which causes all queries to be run as namespace-scoped thanos tenancy requests.
- Remove namespace from all PromQL queries defined in `frontend/packages/console-shared/src/promql/resource-metrics.ts`. These queries will always be run as namespace-scoped tenancy endpoint requests, so including the namespace in the PromQL query is redundant.
- Adjust dev console top workload metrics "Recieve bandwidth" PromQL query to use `namespace=` rather than `namespace=~`. This was causing a `400: Bad Request` on tenancy requests witn `namespace` in the URL query parameters.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

@TheRealJon: This pull request references Bugzilla bug 2015806, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2015806: Fix resource metrics 403 errors for project admin users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 27, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Oct 27, 2021
* on (namespace,pod) group_left(workload,workload_type) namespace_workload_pod:kube_pod_owner:relabel{
namespace=~'<%= namespace %>', workload=~'<%= workloadName %>', workload_type='<%= workloadType %>'}) by (pod)`,
namespace='<%= namespace %>', workload=~'<%= workloadName %>', workload_type='<%= workloadType %>'}) by (pod)`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should also be = rather than =~ for workload, although I realize that's not directly related to the bug this PR is fixing.

@kyoto
Copy link
Member

kyoto commented Oct 28, 2021

/lgtm
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@kyoto
Copy link
Member

kyoto commented Oct 28, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@kyoto: This pull request references Bugzilla bug 2015806, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei October 28, 2021 00:27
@openshift-merge-robot openshift-merge-robot merged commit f70d78d into openshift:master Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 2015806 has been moved to the MODIFIED state.

In response to this:

Bug 2015806: Fix resource metrics 403 errors for project admin users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@TheRealJon: new pull request created: #10396

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants