New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2014471: Open Helm Release notes tab automatically after installing a chart #10481
Bug 2014471: Open Helm Release notes tab automatically after installing a chart #10481
Conversation
@debsmita1: This pull request references Bugzilla bug 2014471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/assign @jerolimov |
@debsmita1: This pull request references Bugzilla bug 2014471, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change request so that the translation team is not confused why we want to translate "Release+notes". It should work then also directly for the other languages because "Release notes" is already translated.
@@ -66,6 +66,7 @@ | |||
"A unique name for the Helm Chart release.": "A unique name for the Helm Chart release.", | |||
"Errors in the form - {{errorsText}}": "Errors in the form - {{errorsText}}", | |||
"Invalid YAML - {{err}}": "Invalid YAML - {{err}}", | |||
"Release+notes": "Release+notes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My hope is that we can skip the extra translation.
"Release+notes": "Release+notes", |
redirect = `${config.redirectURL}?selectId=${secretId}&selectTab=${t( | ||
'helm-plugin~Release+notes', | ||
)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also work if you use the same title here which already exists. The browsers will automatically add +
or %20
to escape this, or you use encodeURIComponent
:
redirect = `${config.redirectURL}?selectId=${secretId}&selectTab=${t( | |
'helm-plugin~Release+notes', | |
)}`; | |
redirect = `${config.redirectURL}?selectId=${secretId}&selectTab=${encodeURIComponent((t( | |
'helm-plugin~Release notes', | |
))}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , it works without the +
, the browser automatically adds it
cd6702e
to
72c030c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, tested also with the translated languages.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@debsmita1: All pull requests linked via external trackers have merged: Bugzilla bug 2014471 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2014471
Root analysis:
the
Release notes
tab name is not internationalizedSolution description:
added i18n for
Release notes
tab nameGIF: