Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2014471: Open Helm Release notes tab automatically after installing a chart #10481

Merged
merged 1 commit into from Nov 18, 2021

Conversation

debsmita1
Copy link
Contributor

@debsmita1 debsmita1 commented Nov 16, 2021

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2014471

Root analysis:
the Release notes tab name is not internationalized

Solution description:
added i18n for Release notes tab name

GIF:
helm-release-notes

@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Nov 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@debsmita1: This pull request references Bugzilla bug 2014471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2014471: Open Helm Release notes tab automatically after installing a chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 16, 2021
@openshift-ci openshift-ci bot added the component/helm Related to helm-plugin label Nov 16, 2021
@debsmita1
Copy link
Contributor Author

/kind bug

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Nov 16, 2021
@debsmita1
Copy link
Contributor Author

/assign @jerolimov

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@debsmita1: This pull request references Bugzilla bug 2014471, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2014471: Open Helm Release notes tab automatically after installing a chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change request so that the translation team is not confused why we want to translate "Release+notes". It should work then also directly for the other languages because "Release notes" is already translated.

@@ -66,6 +66,7 @@
"A unique name for the Helm Chart release.": "A unique name for the Helm Chart release.",
"Errors in the form - {{errorsText}}": "Errors in the form - {{errorsText}}",
"Invalid YAML - {{err}}": "Invalid YAML - {{err}}",
"Release+notes": "Release+notes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hope is that we can skip the extra translation.

Suggested change
"Release+notes": "Release+notes",

Comment on lines 205 to 207
redirect = `${config.redirectURL}?selectId=${secretId}&selectTab=${t(
'helm-plugin~Release+notes',
)}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also work if you use the same title here which already exists. The browsers will automatically add + or %20 to escape this, or you use encodeURIComponent:

Suggested change
redirect = `${config.redirectURL}?selectId=${secretId}&selectTab=${t(
'helm-plugin~Release+notes',
)}`;
redirect = `${config.redirectURL}?selectId=${secretId}&selectTab=${encodeURIComponent((t(
'helm-plugin~Release notes',
))}`;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , it works without the + , the browser automatically adds it

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, tested also with the translated languages.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@jerolimov
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 314a560 into openshift:master Nov 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

@debsmita1: All pull requests linked via external trackers have merged:

Bugzilla bug 2014471 has been moved to the MODIFIED state.

In response to this:

Bug 2014471: Open Helm Release notes tab automatically after installing a chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/helm Related to helm-plugin kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants