New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1985933: Improved label matching, added more options for registry suggestions #10493
Bug 1985933: Improved label matching, added more options for registry suggestions #10493
Conversation
@metalice: This pull request references Bugzilla bug 1985933, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fd32cc8
to
9f23827
Compare
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
9f23827
to
ba4bd26
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@metalice: All pull requests linked via external trackers have merged: Bugzilla bug 1985933 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matan Schatzman mschatzm@redhat.com
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1985933
Analysis / Root cause:
Input should suggest matching registry examples based on os version
Solution Description:
Added more options to labels according to os versions.
Screen shots / Gifs for design review:
Example for RHLE