Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2025481: Update VM Snapshots UI #10510

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Nov 18, 2021

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2025481
https://issues.redhat.com/browse/CNV-13716

Analysis / Root cause:
when attaching an auto-detach hotplug volume, we attach it to VMI,
VM YAML is holding the volume that can be snapshotted under status.volumeSnapshotStatuses

Solution Description:
represent existing auto-detach hotplug volumes to be unsupported for snapshot

Screen shots / Gifs for design review:

before:

before

after:

after

Signed-off-by: Aviv Turgeman aturgema@redhat.com

Signed-off-by: Aviv Turgeman aturgema@redhat.com

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Nov 18, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Nov 18, 2021

@pcbailey please review same like #10507 - all tests kept failing so re opened a new PR

@avivtur
Copy link
Contributor Author

avivtur commented Nov 21, 2021

/retest

1 similar comment
@yaacov
Copy link
Member

yaacov commented Nov 21, 2021

/retest

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the allow_hotplugs_with_snapshots_2 branch from f5ed268 to 5695ebd Compare November 21, 2021 15:59
@metalice
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Nov 21, 2021

/retest

1 similar comment
@avivtur
Copy link
Contributor Author

avivtur commented Nov 22, 2021

/retest

@avivtur avivtur changed the title CNV-13716: Update VM Snapshots UI Bug 2025481: Update VM Snapshots UI Nov 22, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

@avivtur: This pull request references Bugzilla bug 2025481, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2025481: Update VM Snapshots UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 22, 2021
@openshift-ci openshift-ci bot requested a review from gouyang November 22, 2021 10:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

@avivtur: This pull request references Bugzilla bug 2025481, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2025481: Update VM Snapshots UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur
Copy link
Contributor Author

avivtur commented Nov 22, 2021

/retest

6 similar comments
@avivtur
Copy link
Contributor Author

avivtur commented Nov 22, 2021

/retest

@avivtur
Copy link
Contributor Author

avivtur commented Nov 22, 2021

/retest

@avivtur
Copy link
Contributor Author

avivtur commented Nov 22, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Nov 23, 2021

/retest

@avivtur
Copy link
Contributor Author

avivtur commented Nov 23, 2021

/retest

@avivtur
Copy link
Contributor Author

avivtur commented Nov 23, 2021

/retest

@metalice
Copy link
Contributor

/lgtm

@avivtur
Copy link
Contributor Author

avivtur commented Nov 24, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Nov 25, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9502102 into openshift:master Nov 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2021

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2025481 has been moved to the MODIFIED state.

In response to this:

Bug 2025481: Update VM Snapshots UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants