Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1946232: VM List high CPU usage #10572

Closed
wants to merge 1 commit into from
Closed

Bug 1946232: VM List high CPU usage #10572

wants to merge 1 commit into from

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Nov 29, 2021 •
edited

Attempt to further optimize the VM list status rendering.

  • vmStatus won't be computed anymore since the backend printableStatus is more mature.
  • Using the new ListPage components for better memoization

Screen Shot 2021-12-21 at 17 28 28

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

@glekner: This pull request references Bugzilla bug 1946232, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1946232: VM List high CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 29, 2021
@openshift-ci openshift-ci bot requested a review from gouyang November 29, 2021 11:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

@glekner: This pull request references Bugzilla bug 1946232, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1946232: VM List high CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glekner
Copy link
Contributor Author

glekner commented Nov 30, 2021

/retest

3 similar comments
@glekner
Copy link
Contributor Author

glekner commented Nov 30, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Nov 30, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 1, 2021

/retest

@glekner glekner force-pushed the fix-1946232-nov21 branch 2 times, most recently from 73ed6ee to 8288c6e Compare December 2, 2021 15:02
@glekner
Copy link
Contributor Author

glekner commented Dec 4, 2021

/retest

1 similar comment
@glekner
Copy link
Contributor Author

glekner commented Dec 5, 2021

/retest

@gouyang
Copy link
Contributor

gouyang commented Dec 7, 2021

/test kubevirt-plugin

@glekner
Copy link
Contributor Author

glekner commented Dec 7, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 8, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 9, 2021

/retest

1 similar comment
@glekner
Copy link
Contributor Author

glekner commented Dec 15, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 19, 2021

/retest

1 similar comment
@glekner
Copy link
Contributor Author

glekner commented Dec 20, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 20, 2021

/test kubevirt-plugin

@glekner
Copy link
Contributor Author

glekner commented Dec 20, 2021

/retest

1 similar comment
@gouyang
Copy link
Contributor

gouyang commented Dec 21, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@glekner: This pull request references Bugzilla bug 1946232, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1946232: VM List high CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@glekner: This pull request references Bugzilla bug 1946232, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1946232: VM List high CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Dec 21, 2021
@glekner
Copy link
Contributor Author

glekner commented Dec 21, 2021

@gouyang @tnisan @yaacov please check PR description
for more detailed status (previous expensive vmStatus) the user will have to go to a specific vm details page

@glekner
Copy link
Contributor Author

glekner commented Dec 21, 2021

/retest

5 similar comments
@gouyang
Copy link
Contributor

gouyang commented Dec 22, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 22, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 22, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 23, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Dec 25, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 25, 2021

@glekner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-plugin a198b5d link true /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@glekner glekner closed this Dec 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 26, 2021

@glekner: This pull request references Bugzilla bug 1946232. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1946232: VM List high CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouyang gouyang Awaiting requested review from gouyang

@rawagner rawagner Awaiting requested review from rawagner

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glekner @gouyang