New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2028160: Remove i18nKey in network-policy-peer-selectors.tsx #10642
Bug 2028160: Remove i18nKey in network-policy-peer-selectors.tsx #10642
Conversation
@TimG1997: This pull request references Bugzilla bug 2028160, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/console-app/src/components/network-policies/network-policy-peer-selectors.tsx
Outdated
Show resolved
Hide resolved
<Trans ns="console-app"> | ||
Show a preview of the{' '} | ||
<Button | ||
data-test={`show-affected-pods-${props.direction}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment: maybe you can replace this line by:
data-test={`show-affected-pods-${props.direction}`} | |
data-test={`show-affected-pods-egress`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the `s here and move to a string.
data-test={`show-affected-pods-${props.direction}`} | |
data-test="show-affected-pods-egress" |
/bugzilla refresh |
@TimG1997: This pull request references Bugzilla bug 2028160, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'm not seeing any errors.
I'm happy to lgtm this once @mariomac's comments are resolved. (I think they're making a good point.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Please squash your commits and reach out to an approver for final approval. (They are listed in the OWNERS file.)
Make sure that the translation of the affected pods link works correctly and appears in correct form in the console-app.json file. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2028160husky
5704c28
to
1a698a4
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after the squash!
/assign @jotak |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak, mariomac, rebeccaalpert, TimG1997 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Looks like a test flake. /retest |
@TimG1997: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@TimG1997: All pull requests linked via external trackers have merged: Bugzilla bug 2028160 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rebeccaalpert Make sure that the translation of the affected pods link works correctly and appears in correct form in the console-app.json file.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2028160