Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2028160: Remove i18nKey in network-policy-peer-selectors.tsx #10642

Conversation

timgrein
Copy link
Contributor

@timgrein timgrein commented Dec 9, 2021

@rebeccaalpert Make sure that the translation of the affected pods link works correctly and appears in correct form in the console-app.json file.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2028160

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Dec 9, 2021
@jcaianirh jcaianirh changed the title Bug 2028160 - Remove i18nKey in network-policy-peer-selectors.tsx Bug 2028160: Remove i18nKey in network-policy-peer-selectors.tsx Dec 9, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

@TimG1997: This pull request references Bugzilla bug 2028160, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2028160: Remove i18nKey in network-policy-peer-selectors.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

<Trans ns="console-app">
Show a preview of the{' '}
<Button
data-test={`show-affected-pods-${props.direction}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment: maybe you can replace this line by:

Suggested change
data-test={`show-affected-pods-${props.direction}`}
data-test={`show-affected-pods-egress`}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop the `s here and move to a string.

Suggested change
data-test={`show-affected-pods-${props.direction}`}
data-test="show-affected-pods-egress"

@timgrein
Copy link
Contributor Author

timgrein commented Dec 9, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

@TimG1997: This pull request references Bugzilla bug 2028160, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei December 9, 2021 15:01
Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm not seeing any errors.

I'm happy to lgtm this once @mariomac's comments are resolved. (I think they're making a good point.)

Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Please squash your commits and reach out to an approver for final approval. (They are listed in the OWNERS file.)

@rebeccaalpert rebeccaalpert added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
Make sure that the translation of the affected pods link works correctly and appears in correct form in the console-app.json file.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2028160husky
@timgrein timgrein force-pushed the i18n-key-translation-network-policy-fix branch from 5704c28 to 1a698a4 Compare December 14, 2021 15:42
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after the squash!

@rebeccaalpert rebeccaalpert added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@timgrein
Copy link
Contributor Author

/assign @jotak

@jotak
Copy link
Contributor

jotak commented Dec 14, 2021

/approve
thanks @TimG1997 !

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, mariomac, rebeccaalpert, TimG1997

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rebeccaalpert
Copy link
Contributor

Looks like a test flake.

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@TimG1997: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8b730d4 into openshift:master Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@TimG1997: All pull requests linked via external trackers have merged:

Bugzilla bug 2028160 has been moved to the MODIFIED state.

In response to this:

Bug 2028160: Remove i18nKey in network-policy-peer-selectors.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timgrein timgrein deleted the i18n-key-translation-network-policy-fix branch December 16, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants