Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2033407: Fix secure route pre-filled issue in edit flow #10687

Merged
merged 1 commit into from Dec 17, 2021

Conversation

vikram-raj
Copy link
Member

Fix: https://bugzilla.redhat.com/show_bug.cgi?id=2033407

Analysis / Root cause:
Route data is not pre-filled in the edit form. We are reading the tls data from the Route spec instead of spec.tls. And we are using the wrong key I:e privateKey which should be key.

Solution Description:
Read the Route tls data from spec.tls and changed privateKey to 'key`.

GIF:
Kapture 2021-12-17 at 18 56 18

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@vikram-raj: This pull request references Bugzilla bug 2033407, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2033407: Fix secure route pre-filled issue in edit flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/knative Related to knative-plugin labels Dec 17, 2021
@vikram-raj
Copy link
Member Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 17, 2021
@vikram-raj
Copy link
Member Author

/cc @karthikjeeyar

@vikram-raj
Copy link
Member Author

cc @jerolimov

@jerolimov
Copy link
Member

/cc
/assign

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When disable the Secure setting the Route tls options are not removed, so that when I open the edit page again it is enabled again. Please let us fix this as part of this PR as well., :)

@vikram-raj
Copy link
Member Author

When disable the Secure setting the Route tls options are not removed, so that when I open the edit page again it is enabled again. Please let us fix this as part of this PR as well., :)

Fixed this scenario as well.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Good catch to find this really old issue. Let us backport this as soon as this is merged. 👍

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7647c58 into openshift:master Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@vikram-raj: All pull requests linked via external trackers have merged:

Bugzilla bug 2033407 has been moved to the MODIFIED state.

In response to this:

Bug 2033407: Fix secure route pre-filled issue in edit flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the bz-2033407 branch December 18, 2021 02:56
@vikram-raj
Copy link
Member Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@vikram-raj: #10687 failed to apply on top of branch "release-4.9":

Applying: Fix secure route pre-filled issue in edit flow
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts
A	frontend/packages/dev-console/src/components/import/advanced/__tests__/RouteSection.spec.tsx
M	frontend/packages/dev-console/src/components/import/import-types.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/import/import-types.ts
CONFLICT (modify/delete): frontend/packages/dev-console/src/components/import/advanced/__tests__/RouteSection.spec.tsx deleted in HEAD and modified in Fix secure route pre-filled issue in edit flow. Version Fix secure route pre-filled issue in edit flow of frontend/packages/dev-console/src/components/import/advanced/__tests__/RouteSection.spec.tsx left in tree.
Auto-merging frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix secure route pre-filled issue in edit flow
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants