New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2033407: Fix secure route pre-filled issue in edit flow #10687
Conversation
@vikram-raj: This pull request references Bugzilla bug 2033407, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/cc @karthikjeeyar |
cc @jerolimov |
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When disable the Secure setting the Route tls options are not removed, so that when I open the edit page again it is enabled again. Please let us fix this as part of this PR as well., :)
ff40e41
to
e9ed088
Compare
Fixed this scenario as well. |
e9ed088
to
7544293
Compare
7544293
to
167c8ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Good catch to find this really old issue. Let us backport this as soon as this is merged. 👍
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vikram-raj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@vikram-raj: All pull requests linked via external trackers have merged: Bugzilla bug 2033407 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.9 |
@vikram-raj: #10687 failed to apply on top of branch "release-4.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=2033407
Analysis / Root cause:
Route data is not pre-filled in the edit form. We are reading the
tls
data from theRoute
spec
instead ofspec.tls
. And we are using the wrong key I:eprivateKey
which should bekey
.Solution Description:
Read the
Route
tls
data fromspec.tls
and changedprivateKey
to 'key`.GIF: