Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2035772: AccessMode and VolumeMode is not reserved for customize wizard #10743

Merged
merged 1 commit into from Jan 3, 2022

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Dec 28, 2021

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2035772

Analysis / Root cause:
when switching to customize wizard, we initialize volumeMode and accessMode from configMap setting instead of getting the user input from the simple wizard

Solution Description:
adding volumeMode and accessMode under initialData

Screen shots / Gifs for design review:

After:

after.mp4

Signed-off-by: Aviv Turgeman aturgema@redhat.com

…wizard

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 28, 2021

@avivtur: This pull request references Bugzilla bug 2035772, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2035772: AccessMode and VolumeMode is not reserved for customize wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Dec 28, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Dec 28, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 28, 2021

@avivtur: This pull request references Bugzilla bug 2035772, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 28, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Dec 28, 2021

@glekner please review

@yaacov
Copy link
Member

yaacov commented Jan 3, 2022

/retest

@yaacov
Copy link
Member

yaacov commented Jan 3, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 3, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

@avivtur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e5814b0 into openshift:master Jan 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2035772 has been moved to the MODIFIED state.

In response to this:

Bug 2035772: AccessMode and VolumeMode is not reserved for customize wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants