Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2039770: Monitoring: use namespace to detect the active perspective instead of useActivePerspective hook #10836

Merged
merged 1 commit into from Jan 17, 2022

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Jan 13, 2022

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2039770

Analysis / Root cause:
When the user opens the Observe > Dashboard in admin or developer perspective and switches the perspective in another tab, the observe dashboard doesn't load the right time-range from the browser URL and does not react to any time-range change.

Solution Description:
use namespace to detect the active perspective instead of useActivePerspective hook

Screen shots / Gifs for design review:
Kapture 2022-01-13 at 18 12 17

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@vikram-raj: This pull request references Bugzilla bug 2039770, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2039770: Monitoring: use namespace to detect the active perspective instead of useActivePerspective hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@vikram-raj: This pull request references Bugzilla bug 2039770, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2039770: Monitoring: use namespace to detect the active perspective instead of useActivePerspective hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/cc @kyoto

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring labels Jan 13, 2022
@vikram-raj
Copy link
Member Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 13, 2022
@kyoto
Copy link
Member

kyoto commented Jan 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c37a766 into openshift:master Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@vikram-raj: All pull requests linked via external trackers have merged:

Bugzilla bug 2039770 has been moved to the MODIFIED state.

In response to this:

Bug 2039770: Monitoring: use namespace to detect the active perspective instead of useActivePerspective hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the bz-2039770 branch January 17, 2022 05:50
@vikram-raj
Copy link
Member Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@vikram-raj: #10836 failed to apply on top of branch "release-4.9":

Applying: Monitoring: use namespace to detect the activePerspective instead of useActivePerspective hook
Using index info to reconstruct a base tree...
M	frontend/public/components/monitoring/dashboards/graph.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/monitoring/dashboards/graph.tsx
CONFLICT (content): Merge conflict in frontend/public/components/monitoring/dashboards/graph.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Monitoring: use namespace to detect the activePerspective instead of useActivePerspective hook
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@vikram-raj: #10836 failed to apply on top of branch "release-4.9":

Applying: Monitoring: use namespace to detect the activePerspective instead of useActivePerspective hook
Using index info to reconstruct a base tree...
M	frontend/public/components/monitoring/dashboards/graph.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/monitoring/dashboards/graph.tsx
CONFLICT (content): Merge conflict in frontend/public/components/monitoring/dashboards/graph.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Monitoring: use namespace to detect the activePerspective instead of useActivePerspective hook
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants