New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2013127: allow catalog categories and cards to open in new tab #10853
Conversation
@rhamilto: This pull request references Bugzilla bug 2013127, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: This pull request references Bugzilla bug 2013127, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: This pull request references Bugzilla bug 2013127, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rhamilto: This pull request references Bugzilla bug 2013127, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@rhamilto: This pull request references Bugzilla bug 2013127, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rhamilto, for picking this up and the explanation why this doesn't work yet for ctrl+click and the checkboxes.
Verified this locally and works fine. 👍
I subscribed these PF issue, when this is fixed and we upgrade I would check again and create a new BZ issue if needed.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rhamilto: This pull request references Bugzilla bug 2013127, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: All pull requests linked via external trackers have merged: Bugzilla bug 2013127 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ctrl/Cmd + Click does not work on category filters as e.preventDefault() is always fired in
<VerticalTabsTab>
. I've opened an upstream issue to address --> see patternfly/patternfly-react#6805.Ctrl/Cmd + Click-ing a tile in the OperatorHub can result in bypassing the optional community operator warning modal, but this is the same behavior that occurs if you manually navigate to the URL directly or refresh the browser (in other words, this is an existing bug).
Screen.Recording.2022-01-14.at.5.15.15.PM.mov
Note the Bugzilla mentions this bug also exists on the
Source
filters, but that is erroneous as the source filters are checkboxes and not links.