New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2038772: Monitoring: Handle service monitors with undefined matchLabels #10854
Bug 2038772: Monitoring: Handle service monitors with undefined matchLabels #10854
Conversation
When `matchLabels` is `undefined`, we should still match services if the namespace matches.
@kyoto: This pull request references Bugzilla bug 2038772, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, lihongyan1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@kyoto: All pull requests linked via external trackers have merged: Bugzilla bug 2038772 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kyoto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
FYI @spadgett. It seems this got merged without code review. |
@@ -52,7 +52,8 @@ const ServiceMonitor: React.FC<{ target: Target }> = ({ target }) => { | |||
monitors, | |||
({ spec }) => | |||
service && | |||
new LabelSelector(spec.selector).matchesLabels(service.metadata.labels ?? {}) && | |||
(spec.selector.matchLabels === undefined || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to handle matchExpressions
as well? I believe LabelSelector
supports matchExpressions
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I created a follow up PR to handle this: #10877
When
matchLabels
isundefined
, we should still match services if thenamespace matches.