Bug 2069654: Adding missing annotations to create VM from YAML

[avivtur]

Adding missing annotation for flavor os and workload

demo:

bz2069654-after.mp4

YAML file example:

apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  name: vm-example
  labels:
    app: vm-example
    os.template.kubevirt.io/fedora35: 'true'
    flavor.template.kubevirt.io/small: 'true'
    vm.kubevirt.io/template: fedora-server-small
    workload.template.kubevirt.io/server: 'true'
  annotations:
    name.os.template.kubevirt.io/fedora35: Fedora 35
    description: VM example
  namespace: default
spec:
  running: false
  template:
    metadata:
      annotations:
        vm.kubevirt.io/flavor: small
        vm.kubevirt.io/os: fedora
        vm.kubevirt.io/workload: server
      labels:
        flavor.template.kubevirt.io/small: 'true'
        kubevirt.io/domain: vm-example
        kubevirt.io/size: small
        vm.kubevirt.io/name: vm-example
        os.template.kubevirt.io/fedora35: 'true'
        workload.template.kubevirt.io/server: 'true'
    spec:
      domain:
        cpu:
          cores: 1
          sockets: 1
          threads: 1
        devices:
          disks:
            - bootOrder: 1
              disk:
                bus: virtio
              name: containerdisk
            - disk:
                bus: virtio
              name: cloudinitdisk
          interfaces:
            - masquerade: {}
              name: default
              model: virtio
          networkInterfaceMultiqueue: true
          rng: {}
        resources:
          requests:
            memory: 1G
      hostname: vm-example
      networks:
        - name: default
          pod: {}
      terminationGracePeriodSeconds: 0
      volumes:
        - containerDisk:
            image: 'quay.io/containerdisks/fedora:35'
          name: containerdisk
        - cloudInitNoCloud:
            userData: |-
              #cloud-config
              password: fedora
              chpasswd: { expire: False }
          name: cloudinitdisk

Signed-off-by: Aviv Turgeman aturgema@redhat.com

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 2069654, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2069654: Adding missing annotations to create VM from YAML

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [avivtur,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@avivtur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@avivtur: All pull requests linked via external trackers have merged:

• openshift/console#11518

Bugzilla bug 2069654 has been moved to the MODIFIED state.

In response to this:

Bug 2069654: Adding missing annotations to create VM from YAML

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@yaacov: #11518 failed to apply on top of branch "release-4.10":

Applying: Bug 2069654: Adding missing annotations to create VM from YAML
Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/src/models/templates/vm-yaml.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/src/models/templates/vm-yaml.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/src/models/templates/vm-yaml.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2069654: Adding missing annotations to create VM from YAML
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

@avivtur hi,
I don't know why can't auot-backport :-(
can you make a manual backport ?

[yaacov]

BZ for 4.10 - https://bugzilla.redhat.com/show_bug.cgi?id=2087932

[avivtur]

should we also update the os to fedora 35 as well?
https://github.com/openshift/console/pull/11500/files#diff-afdb4f5b77c22704b39db0adf43eb0cd423943df042fbf9755a398918ea2413d

[yaacov]

both need to get backported

[yaacov]

I'll try to automatically cherry pick this one again, after #11500 gets cherry-picked

[yaacov]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@yaacov: new pull request created: #11527

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.