Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2074635: fix web terminal start #11597

Merged

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented May 30, 2022

Issue

https://bugzilla.redhat.com/show_bug.cgi?id=2074635

Problem

For developer users, web-terminal goes into a loading loop once the devworkspace CR is deleted

Screenshots

fix-terminal-start

Steps to verify

  • Spin a cluster using this PR launch openshift/console#11597 gcp (if not done already)
  • Install WebTerminal Operator from Operator Hub.
  • Add a developer user.
  • Logout and login using a developer user.
  • As a developer user Start Web terminal by clicking on masthead terminal icon.
  • Select namespace and start terminal.
  • Once terminal is UP, go to Search and search for devworkspace CR.
  • Delete the devworkspace resource for the namespace which was used to initialise the terminal.

Desired Outcome

The select namespace (Web Terminal setup screen) should show up again

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2074635: fix web terminal start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2074635: fix web terminal start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2074635: fix web terminal start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinandan13jan abhinandan13jan changed the title Bug 2074635: fix web terminal start [WIP]Bug 2074635: fix web terminal start May 30, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@abhinandan13jan abhinandan13jan changed the title [WIP]Bug 2074635: fix web terminal start Bug 2074635: fix web terminal start May 30, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@abhinandan13jan abhinandan13jan changed the title Bug 2074635: fix web terminal start [WIP]Bug 2074635: fix web terminal start May 30, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@abhinandan13jan abhinandan13jan force-pushed the fix-terminal-start branch 4 times, most recently from 9052401 to 7ddfc33 Compare May 31, 2022 15:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[WIP]Bug 2074635: fix web terminal start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -83,6 +83,7 @@ const useCloudShellWorkspace = (

// call k8s api to fetch workspace
const [data, loaded, loadError] = useK8sWatchResource<CloudShellResource[]>(resource);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove new line

@abhinandan13jan abhinandan13jan changed the title [WIP]Bug 2074635: fix web terminal start Bug 2074635: fix web terminal start May 31, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2022
@invincibleJai
Copy link
Member

Verified the changes with the bot and works as expected

  • For Admin

WTO_WS_ADMIN

  • For Dev

WTO_WS_DEV

@invincibleJai
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD be52a5d and 8 for PR HEAD 031a798 in total

@abhinandan13jan
Copy link
Contributor Author

/cherrypick 4.10

@openshift-cherrypick-robot

@abhinandan13jan: once the present PR merges, I will cherry-pick it on top of 4.10 in a new PR and assign it to you.

In response to this:

/cherrypick 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinandan13jan
Copy link
Contributor Author

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 1, 2022
@abhinandan13jan
Copy link
Contributor Author

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jun 1, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 796673e and 7 for PR HEAD 031a798 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@abhinandan13jan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 38be6ed into openshift:master Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@abhinandan13jan: All pull requests linked via external trackers have merged:

Bugzilla bug 2074635 has been moved to the MODIFIED state.

In response to this:

Bug 2074635: fix web terminal start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abhinandan13jan: cannot checkout 4.10: error checking out 4.10: exit status 1. output: error: pathspec '4.10' did not match any file(s) known to git

In response to this:

/cherrypick 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member

/cherrypick release 4.10

@openshift-cherrypick-robot

@invincibleJai: cannot checkout release 4.10: error checking out release 4.10: exit status 1. output: error: pathspec 'release 4.10' did not match any file(s) known to git

In response to this:

/cherrypick release 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member

/cherry-pick release-4.10

@openshift-cherrypick-robot

@invincibleJai: new pull request created: #11672

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants