New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2074635: fix web terminal start #11597
Bug 2074635: fix web terminal start #11597
Conversation
|
@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c90f9f9
to
49d259a
Compare
9052401
to
7ddfc33
Compare
|
@abhinandan13jan: This pull request references Bugzilla bug 2074635, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -83,6 +83,7 @@ const useCloudShellWorkspace = ( | |||
|
|
|||
| // call k8s api to fetch workspace | |||
| const [data, loaded, loadError] = useK8sWatchResource<CloudShellResource[]>(resource); | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove new line
7ddfc33
to
031a798
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick 4.10 |
|
@abhinandan13jan: once the present PR merges, I will cherry-pick it on top of 4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label qe-approved |
|
/label px-approved |
|
@abhinandan13jan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@abhinandan13jan: All pull requests linked via external trackers have merged: Bugzilla bug 2074635 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhinandan13jan: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release 4.10 |
|
@invincibleJai: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.10 |
|
@invincibleJai: new pull request created: #11672 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |


Issue
https://bugzilla.redhat.com/show_bug.cgi?id=2074635
Problem
For developer users, web-terminal goes into a
loadingloop once thedevworkspaceCR is deletedScreenshots
Steps to verify
launch openshift/console#11597 gcp(if not done already)masthead terminal icon.Searchand search fordevworkspaceCR.devworkspaceresource for thenamespacewhich was used to initialise the terminal.Desired Outcome
The select namespace (Web Terminal setup screen) should show up again