New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2090895: Support startsWith Nav Extension property #11660
Bug 2090895: Support startsWith Nav Extension property #11660
Conversation
@andrewballantyne: This pull request references Bugzilla bug 2090895, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@andrewballantyne: This pull request references Bugzilla bug 2090895, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Jeff, do you ever recall this working when you were reworking our nav to support pinned items back a couple years ago? |
I don't recall it working like this before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sections also need to be marked as active when a child is active. Check out the static startsWith
function that's already implemented on the NavLink
class. I'm not sure why this was never used, but we could use it in all of the inheriting classes so that this function will just work.
2700e4e
to
ebe1717
Compare
Yup, the test scenario was not part of what I was testing. Good catch. To test this you'll need to add an extension that uses |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@andrewballantyne: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@andrewballantyne: All pull requests linked via external trackers have merged: Bugzilla bug 2090895 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Supporting
startsWith
from the navigation extensions.I'm a bit unsure if it was ever supported. Quick searching of the history appears it was not supported in this manner.
To test this, you simply need to add a snippet like this one to any
console.navigation/href
,console.navigation/resource-ns
orconsole.navigation/resource-cluster
extension in thedynamic-demo-plugin
.Then navigate to any of the Dynamic Plugin routes that start with
test
and the navs whom you modified will highlight./assign @TheRealJon