Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render icon as a svg instead of img tag to support dark theme #11663

Merged
merged 1 commit into from Jun 10, 2022
Merged

Render icon as a svg instead of img tag to support dark theme #11663

merged 1 commit into from Jun 10, 2022

Conversation

vikram-raj
Copy link
Member

Story: https://issues.redhat.com/browse/ODC-6676

Descriptions:

  • Render the icon as a SVG instead of img tag on Add page to support the dark theme

Screenshots:
image

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk labels Jun 7, 2022
@vikram-raj
Copy link
Member Author

/cc @jerolimov

@openshift-ci openshift-ci bot requested a review from jerolimov June 7, 2022 17:42
@vikram-raj
Copy link
Member Author

/assign @jerolimov

@lokanandaprabhu
Copy link
Contributor

lokanandaprabhu commented Jun 8, 2022 •
edited

image

image

Hi @vikram-raj , I noticed one thing from above screenshots, the icon and the text not aligned properly for Broker, Channel and Helm Chart. There is styling of vertical-align: -0.125em; for all other menu options except Broker, Channel and Helm Charts.

This is existing from before not due to your changes but can we corret it here? It looked odd for me so pointing it out.

@vikram-raj
Copy link
Member Author

@lokanandaprabhu added vertical-align. PTAL again. Thanks

@lokanandaprabhu
Copy link
Contributor

@lokanandaprabhu added vertical-align. PTAL again. Thanks

Verified. Thanks.

@lokanandaprabhu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@lokanandaprabhu
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 8, 2022
@vikram-raj
Copy link
Member Author

Propagating docs and px acks from the Epic
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 8, 2022
jerolimov
jerolimov approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vikram-raj 👍 👍 👍

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@vikram-raj
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 8e22765 and 8 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 8e22765 and 7 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8e22765 and 6 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 4943c97 and 5 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 4943c97 and 4 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4943c97 and 3 for PR HEAD 084aed5 in total

@vikram-raj
Copy link
Member Author

/test backend

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 49691dd and 2 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 49691dd and 1 for PR HEAD 084aed5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 49691dd and 0 for PR HEAD 084aed5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 634e7b7 into openshift:master Jun 10, 2022
@vikram-raj vikram-raj deleted the odc-6676 branch June 10, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@jerolimov jerolimov

@lokanandaprabhu lokanandaprabhu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vikram-raj @lokanandaprabhu @openshift-ci-robot @jerolimov @openshift-merge-robot