Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] Bug 2104951: fix bug where Cluster update modal errors weren't displa… #11800

Merged
merged 1 commit into from Jul 20, 2022
Merged

[release-4.11] Bug 2104951: fix bug where Cluster update modal errors weren't displa… #11800

merged 1 commit into from Jul 20, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #11762

/assign rhamilto

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 7, 2022
Merged
@rhamilto
Copy link
Member

rhamilto commented Jul 7, 2022

/backport-risk-assessed

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

@openshift-cherrypick-robot: Bugzilla bug 2096350 has been cloned as Bugzilla bug 2104951. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2104951: fix bug where Cluster update modal errors weren't displa…

In response to this:

[release-4.11] Bug 2096350: fix bug where Cluster update modal errors weren't displa…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2096350: fix bug where Cluster update modal errors weren't displa… [release-4.11] Bug 2104951: fix bug where Cluster update modal errors weren't displa… Jul 7, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2104951, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2096350 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2096350 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

[release-4.11] Bug 2104951: fix bug where Cluster update modal errors weren't displa…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from yapei, kyoto and spadgett July 7, 2022 14:54
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2022
@spadgett spadgett added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 7, 2022
spadgett
spadgett approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

spadgett commented Jul 7, 2022

/refresh

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 548021a and 8 for PR HEAD 1cdddfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 548021a and 7 for PR HEAD 1cdddfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 548021a and 6 for PR HEAD 1cdddfc in total

@yapei
Copy link
Contributor

yapei commented Jul 8, 2022

Screen Shot 2022-07-08 at 10 50 33

/label qe-approved /label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jul 8, 2022
@rhamilto
Copy link
Member

rhamilto commented Jul 8, 2022

/retest

1 similar comment
@rhamilto
Copy link
Member

rhamilto commented Jul 8, 2022

/retest

@rhamilto
Copy link
Member

rhamilto commented Jul 8, 2022

/retests

@rhamilto
Copy link
Member

rhamilto commented Jul 9, 2022

/test e2e-gcp-console

@rhamilto
Copy link
Member

rhamilto commented Jul 9, 2022

/retest

6 similar comments
@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/hold

Depends on #11826 merging in order to fix the flaking create-namespace e2e test

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2022
@jerolimov
Copy link
Member

#11826 is merged

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

OLM descriptor flake. See #11856

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 3060d84 and 5 for PR HEAD 1cdddfc in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit aedad14 into openshift:release-4.11 Jul 20, 2022
6 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2104951 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2104951: fix bug where Cluster update modal errors weren't displa…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@yapei yapei Awaiting requested review from yapei

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @rhamilto @spadgett @openshift-ci-robot @yapei @jerolimov @openshift-merge-robot