SDK - add plain yaml editor

[upalatucci]

Hei guys!!

for this ticket i need to expose the YAMLEditor.

The ResourceYAMLEditor has a lot of other things that I don't need like toolbar, buttons, alerts when something changes, and so on.
ResourceYAMLEditor use YAMLEditor so there will be no issue.

Why don't you just add the monaco-editor or patternly react editor into the plugins repo?
Because the editor ( in particular using YAML language) needs some additional configurations using yaml-language-server and monaco-editor-webpack-plugins that maybe it's not great to have in the plugin repo.

WDYT? @vojtechszocs

[upalatucci]

/retest

[spadgett]

Hi, I'm OK exposing this component, but we need to make sure it's lazy-loaded and add more complete documentation. Assume the person reading this is a developer who only has the doc and can't inspect the code to see how the props are used.

[upalatucci]

Hei @spadgett thanks for your feedback.
I've pushed now an update following your review.
Let me know if there is anything else I can do better :-)

[upalatucci]

/retest

[upalatucci]

/retest

[spadgett]

Hey @upalatucci you'll need to add the updated API docs to your commit.

dynamic plugin sdk docs are not up to date. Run 'yarn generate-plugin-sdk-docs' then commit changes.

[vojtechszocs]

/lgtm

[spadgett]

/retest

[upalatucci]

/retest

[upalatucci]

/retest

[spadgett]

/assign @yapei @OliviaHY @RickJWagner
for approvals

[RickJWagner]

/label px-approved

[yapei]

consume YAMLEditor in console-demo-plugin

$ git diff src/components/ListPage.tsx
diff --git a/dynamic-demo-plugin/src/components/ListPage.tsx b/dynamic-demo-plugin/src/components/ListPage.tsx
index 5ff8e9e6f8..9a28dae680 100644
--- a/dynamic-demo-plugin/src/components/ListPage.tsx
+++ b/dynamic-demo-plugin/src/components/ListPage.tsx
@@ -13,6 +13,7 @@ import {
   RowProps,
   ResourceLink,
   TableColumn,
+  YAMLEditor
 } from '@openshift-console/dynamic-plugin-sdk';
 
 const columns: TableColumn<K8sResourceCommon>[] = [
@@ -115,6 +116,11 @@ const ListPage = () => {
           loadError={loadError}
         />
       </ListPageBody>
+      <YAMLEditor
+        value="testing"
+        minHeight="100px"
+        showShortcuts
+      />
     </>
   );
 };

we can see YAML editor is rendered

[yapei]

/label qe-approved

[vojtechszocs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

/unassign @OliviaHY
/assign @opayne1

Sorry I must have clicked the wrong name in the autocomplete list :(

[opayne1]

/label docs-approved

[upalatucci]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD dd6fecf and 8 for PR HEAD 8524729 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD dd6fecf and 7 for PR HEAD 8524729 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD dd6fecf and 6 for PR HEAD 8524729 in total

[upalatucci]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 6c4aadd and 5 for PR HEAD 8524729 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 6c4aadd and 4 for PR HEAD 8524729 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6c4aadd and 3 for PR HEAD 8524729 in total

[upalatucci]

/retest

[upalatucci]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 6a16c2b and 2 for PR HEAD 8524729 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD ac5e927 and 1 for PR HEAD 8524729 in total

[openshift-ci]

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.