Bug 2110927: Remove zero from edit yaml page and clear errors when the user press the save button

[jerolimov]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2110927

Analysis / Root cause:

1. The error?.length check added in Bug 2108551: [CI Watcher] Bulk Import e2e test flaking at a high rate #11863 shows a zero if the error array is defined but empty.
2. It also just appends the error to the error array without removing them.

Solution Description:

1. Add > 0 check to the length. Also, create a new errors array if the error was set.
2. Clear all errors when the Save button is pressed similar to saveAll

Screen shots / Gifs for design review:
Before:

before.mp4

After:

after.mp4

Unit test coverage report:

Test setup:
Open any edit yaml page.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind bug
/cc @debsmita1

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2110927, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2110927: Do not show a zero on edit yaml page when there are no errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2110927, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2110927: Do not show a zero on edit yaml page when there are no errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2110927, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2110927: Do not show a zero on edit yaml page when there are no errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/cc @tvu20 @jhadvig

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2110927, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2110927: Do not show a zero on edit yaml page when there are no errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2110927, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2110927: Remove zero from edit yaml page and clear errors when the user press the save button

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/cc @debsmita1

[jerolimov]

/uncc rhamilto spadgett

[jerolimov]

/retest

[openshift-ci]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vikram-raj]

Verified it and it works as expected.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#11877

Bugzilla bug 2110927 has been moved to the MODIFIED state.

In response to this:

Bug 2110927: Remove zero from edit yaml page and clear errors when the user press the save button

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.