Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2080260, Bug 2106372: Update OLM pages to use details and list page extensions for operands when they exist #11883

Merged
merged 2 commits into from Aug 22, 2022
Merged

Bug 2080260, Bug 2106372: Update OLM pages to use details and list page extensions for operands when they exist #11883

merged 2 commits into from Aug 22, 2022

Conversation

TheRealJon
Copy link
Member

  • Update the CSV details page to load and render list and details page extensions for the operands it manages
  • Remove container security route extensions that collide with olm create-operand routes

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@TheRealJon: This pull request references Bugzilla bug 2080260, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2080260: Update OLM pages to use details and list page extensions for operands when they exist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from kyoto and spadgett July 26, 2022 18:53
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Jul 26, 2022
@jhadvig
Copy link
Member

jhadvig commented Jul 26, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@jhadvig: This pull request references Bugzilla bug 2080260, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 26, 2022 20:59
jhadvig
jhadvig approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @TheRealJon 👍

/lgtm
/approve

@jhadvig
Copy link
Member

jhadvig commented Jul 26, 2022

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 33d235f and 8 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 33d235f and 7 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 33d235f and 6 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD dd6fecf and 5 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD dd6fecf and 4 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dd6fecf and 3 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 6c4aadd and 2 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 6c4aadd and 1 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6c4aadd and 0 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision e8667e3 was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2022
@jhadvig
Copy link
Member

jhadvig commented Jul 28, 2022 

Failed Specs:

1) CRD extensions ConsoleExternalLogLink CRD : creates a new test pod to display the ConsoleExternalLogLink instance
   Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
       at listOnTimeout internal/timers.js:554:17
       at processTimers internal/timers.js:497:7
   
   Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
       at listOnTimeout internal/timers.js:554:17
       at processTimers internal/timers.js:497:7
   
   Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
       at listOnTimeout internal/timers.js:554:17
       at processTimers internal/timers.js:497:7

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD a400c53 and 3 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD f5cb26c and 2 for PR HEAD e8667e3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD f5cb26c and 1 for PR HEAD e8667e3 in total

@TheRealJon
Copy link
Member Author

/hold

This is a legit CI failure. There's a RTE encountered during the global operator installation test.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console and removed lgtm Indicates that a PR is ready to be merged. labels Aug 8, 2022
@TheRealJon
Copy link
Member Author

/hold cancel

Found the issue and fixed it and also refactored my solution to simplify it a bit.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2022
@jhadvig
Copy link
Member

jhadvig commented Aug 9, 2022

@TheRealJon the tests are failing with

frontend:

OperandDetailsPage › renders a `DetailsPage` with the correct subpages
    Method “props” is meant to be run on 1 node. 0 found instead.
      
      at ReactWrapper.single (node_modules/enzyme/src/ReactWrapper.js:1166:13)
      at ReactWrapper.props (node_modules/enzyme/src/ReactWrapper.js:710:17)
      at Object.<anonymous> (packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx:391:24)
          at new Promise (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
  ● OperandDetailsPage › renders a `DetailsPage` which also watches the parent CSV
    Method “props” is meant to be run on 1 node. 0 found instead.
      
      at ReactWrapper.single (node_modules/enzyme/src/ReactWrapper.js:1166:13)
      at ReactWrapper.props (node_modules/enzyme/src/ReactWrapper.js:710:17)
      at ReactWrapper.prop (node_modules/enzyme/src/ReactWrapper.js:827:17)
      at Object.<anonymous> (packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx:400:38)
          at new Promise (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
....

console:

2 failing
  1) Globally installing "Service Binding Operator" operator in openshift-operators
       Globally installs Service Binding Operator operator in openshift-operators and creates ServiceBinding operand:
     AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-test="msg-box-title"]`, but never found it.
      at Object.createOperand (https://console-openshift-console.apps.ci-op-q2hl16kt-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-install-global.spec.ts:14235:38)
      at Context.eval (https://console-openshift-console.apps.ci-op-q2hl16kt-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-install-global.spec.ts:14112:71)
  2) Globally installing "Service Binding Operator" operator in openshift-operators
       "after all" hook for "Globally installs Service Binding Operator operator in openshift-operators and creates ServiceBinding operand":
     CypressError: You attempted to make a chai-jQuery assertion on an object that is neither a DOM object or a jQuery object.
...

@jhadvig
Copy link
Member

jhadvig commented Aug 9, 2022

TBH Im not sure what is causing the issue, since the code changes look good.

@TheRealJon
Bug 2080260: Update OLM pages to use details and list page extensions…
0553a9c 
… for operands when they exist

- Update the CSV details page to load and render list and details page extensions for the operands it manages
- Remove container security route extensions that collide with olm create operand routes
@TheRealJon
Copy link
Member Author

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Aug 15, 2022
@TheRealJon
Copy link
Member Author

/retest

jhadvig
jhadvig approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 50fb279 and 8 for PR HEAD fd1aec3 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 34ac339 into openshift:master Aug 22, 2022
6 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 2080260 has been moved to the MODIFIED state.

In response to this:

Bug 2080260: Update OLM pages to use details and list page extensions for operands when they exist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon TheRealJon changed the title Bug 2080260: Update OLM pages to use details and list page extensions for operands when they exist Bug 2080260, Bug 2106372: Update OLM pages to use details and list page extensions for operands when they exist Oct 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 2106372 has been moved to the MODIFIED state.

In response to this:

Bug 2080260, Bug 2106372: Update OLM pages to use details and list page extensions for operands when they exist

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Nov 11, 2022
Merged
@jerolimov jerolimov mentioned this pull request Jan 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM component/shared Related to console-shared kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheRealJon @jhadvig @openshift-ci-robot @openshift-merge-robot