CONSOLE-3237: Add opt out when Console deletes operands #12234

zherman0 · 2022-11-03T01:01:40Z

Console deletes operands regardless of interdependency.
This is built from dtaylor's PR10279

Added the ability for an operator to "opt out" of deleting all operands using an annotation flag: console.openshift.io/disable-operand-delete: "true"

Steps to test:

Using Console UI, create project "test-3237" and then go to Operator Hub and install Business Automation in namespace "test-3237"
Go into operator details for business automation and create instance for kieapps
From the operators installed page, use the kebab and select "uninstall operator"
If the opt out flag is not set, then the new screens showing instructions to delete all operands will appear
4a) If the opt out flag is set, then the uninstall should look and work as it previously did
To change the opt out flag, use the following patch cmds:
oc annotate csv businessautomation-operator.7.13.1-1 console.openshift.io/disable-operand-delete=true
oc annotate csv businessautomation-operator.7.13.1-1 console.openshift.io/disable-operand-delete=false --overwrite

@jhadvig @dtaylor113

https://user-images.githubusercontent.com/12733153/139136191-b6aaa4e3-6849-45c2-95c1-c3aa986fcc8c.gif

zherman0 · 2022-11-03T01:11:01Z

QE Approver
/assign @yapei

Docs Approver:
/assign @opayne1

PX Approver:
/assign @RickJWagner

rhamilto · 2022-11-03T12:11:54Z

@zherman0, it appears you need to re-run yarn i18n.

zherman0 · 2022-11-03T13:55:31Z

Re-ran yarn i18n and quadrupled the number of files in this bug. I will leave the changes assuming this is an okay place to fix those i18n issues.

opayne1 · 2022-11-03T15:42:24Z

/label docs-approved

zherman0 · 2022-11-03T16:18:39Z

/retest

RickJWagner · 2022-11-03T20:14:28Z

Thank you for the gif showing how things work.

/label px-approved

zherman0 · 2022-11-03T20:24:50Z

/retest

jhadvig · 2023-01-03T16:08:22Z


  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      0                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      1                                                                                │
  │ Screenshots:  3                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 16 seconds                                                             │
  │ Spec Ran:     app/auth-multiuser-login.spec.ts                                                 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
  (Screenshots)
  -  /go/src/github.com/openshift/console/frontend/gui_test_screenshots/cypress/scree     (1280x720)
     nshots/app/auth-multiuser-login.spec.ts/Auth test -- logs in as 'test' user via                
     htpasswd identity provider -- after each hook (failed).png                                     
  -  /go/src/github.com/openshift/console/frontend/gui_test_screenshots/cypress/scree     (1280x720)
     nshots/app/auth-multiuser-login.spec.ts/Auth test -- logs in as 'test' user via                
     htpasswd identity provider (failed) (attempt 2).png                                            
  -  /go/src/github.com/openshift/console/frontend/gui_test_screenshots/cypress/scree     (1280x720)
     nshots/app/auth-multiuser-login.spec.ts/Auth test -- logs in as 'test' user via                
     htpasswd identity provider -- after each hook (failed) (attempt 2).png

jhadvig · 2023-01-04T13:35:07Z

same error as before

jcaianirh · 2023-01-04T20:12:10Z

/retest

jhadvig · 2023-01-05T09:04:23Z

  (Run Finished)
       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✖  e2e/add-flow-ci.feature                  13:12       16        8        8        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✖  1 of 1 failed (100%)                     13:12       16        8        8        -        -

/retest

jhadvig · 2023-01-09T09:31:54Z


Failed Specs:
1) Interacting with the environment variable editor When a variable is added from a secret : shows the correct variables
   TimeoutError: Wait timed out after 15004ms
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:2201:17
       at ManagedPromise.invokeCallback_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1376:14
       at TaskQueue.execute_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3084:14
       at TaskQueue.executeNext_ /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3067:27
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:2927:27
       at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:668:7
       at runMicrotasks <anonymous>:null:null
       at processTicksAndRejections internal/process/task_queues.js:93:5

/retest

jhadvig · 2023-01-09T15:32:36Z

Testing uninstall of Business Automation Operator
  Logging in as kubeadmin
      create project
      install operator "Business Automation" in test-rzlcg
      go to operator overview panel
      go to the install form
      configure Operator install for single namespace
      verify namespace dropdown shows the "test-rzlcg" namespace
      verify Operator began installation
      navigate to OperatorHub in Namespace: test-rzlcg
      operator "Business Automation" should exist in openshift-operators
    1) "before all" hook for "installs Business Automation Operator and KieApp Instance, then navigates to Operator details page"
      delete project
    2) "after all" hook for "installs Business Automation Operator and KieApp Instance, then navigates to Operator details page"
  0 passing (4m)
  2 failing
  1) Testing uninstall of Business Automation Operator
       "before all" hook for "installs Business Automation Operator and KieApp Instance, then navigates to Operator details page":
     AssertionError: Timed out retrying after 180000ms: Expected to find element: `[data-test-operator-row="Business Automation"]`, but never found it.
Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Testing uninstall of Busine...`
Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
      at Object.installedSucceeded (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-uninstall.spec.ts:14277:65)
      at Context.eval (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-uninstall.spec.ts:14123:71)
  2) Testing uninstall of Business Automation Operator
       "after all" hook for "installs Business Automation Operator and KieApp Instance, then navigates to Operator details page":
     CypressError: `cy.click()` failed because it requires a DOM element.
The subject received was:
  > `undefined`
The previous command that ran was:
  > `cy.get()`
Because this error occurred during a `after all` hook we are skipping the remaining tests in the current suite: `Testing uninstall of Busine...`
Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
      at ensureElement (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:160549:85)
      at validateType (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:160386:18)
      at Object.ensureSubjectByType (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:160422:11)
      at pushSubjectAndValidate (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:169527:17)
      at Context. (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:169856:20)
  From Your Spec Code:
      at Object.clickPageActionFromDropdown (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-uninstall.spec.ts:13743:50)
      at Context.eval (https://console-openshift-console.apps.ci-op-2pnw5s9q-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-uninstall.spec.ts:13601:69)

zherman0 · 2023-01-09T15:56:34Z

/retest

jhadvig · 2023-01-10T08:10:30Z

error in the same test case. Looks like we have a catch on whats is the issue.
@zherman0 FYI

Testing uninstall of Business Automation Operator
  Logging in as kubeadmin
      create project
      install operator "Business Automation" in test-tzoca
      go to operator overview panel
      go to the install form
      configure Operator install for single namespace
      verify namespace dropdown shows the "test-tzoca" namespace
      verify Operator began installation
      navigate to OperatorHub in Namespace: test-tzoca
      operator "Business Automation" should exist in openshift-operators
      create operand "example-kieappk" for "Business Automation" in test-tzoca
      navigate to details page of operator "Business Automation"
      create a new operand
      operand "example-kieappk" should exist for "Business Automation" in test-tzoca
      navigate to details page of operator "Business Automation"
      navigate to the operand "Details" tab
      navigate to details page of operator "Business Automation"
    ✓ installs Business Automation Operator and KieApp Instance, then navigates to Operator details page (103269ms)
      navigate to details page of operator "Business Automation"
      attempt to uninstall the Operator
      open uninstall modal
      navigate to details page of operator "Business Automation"
    ✓ attempts to uninstall the Operator, shows 'Cannot load Operands' alert (10022ms)
      navigate to details page of operator "Business Automation"
      attempt to uninstall the Operator
      open uninstall modal
      navigate to details page of operator "Business Automation"
      navigate to details page of operator "Business Automation"
    1) "before each" hook for "attempts to uninstall the Operator, shows 'Error uninstalling Operator' alert"
      delete project
  Logging out
  2 passing (3m)
  1 failing
  1) Testing uninstall of Business Automation Operator
       "before each" hook for "attempts to uninstall the Operator, shows 'Error uninstalling Operator' alert":
     CypressError: Timed out retrying after 30050ms: `cy.click()` failed because this element:
`<a data-test="nav" class="pf-c-nav__link pf-m-current" href="/k8s/ns/test-tzoca/operators.coreos.com~v1alpha1~ClusterServiceVersion" aria-current="page">Install...</a>`
is being covered by another element:
`<div class="ReactModal__Overlay ReactModal__Overlay--after-open co-overlay">...</div>`
Fix this problem, or use {force: true} to disable error checking.
https://on.cypress.io/element-cannot-be-interacted-with
Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `Testing uninstall of Busine...`
      at $Cy.ensureDescendents (https://console-openshift-console.apps.ci-op-gi69p3l7-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:160669:87)
      at ensureDescendents (https://console-openshift-console.apps.ci-op-gi69p3l7-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:147543:8)
      at ensureDescendentsAndScroll (https://console-openshift-console.apps.ci-op-gi69p3l7-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/runner/cypress_runner.js:147550:14)
...

jcaianirh · 2023-01-12T21:32:08Z

/retest

jhadvig · 2023-01-16T14:16:43Z

@zherman0 getting closer.

But still there is an issue:

  1) Testing uninstall of Business Automation Operator
       "before all" hook for "installs Business Automation Operator and KieApp Instance, then navigates to Operator details page":
     CypressError: Timed out retrying after 30050ms: `cy.click()` failed because this element is detached from the DOM.
`<a class="co-resource-item__resource-name" data-test-operand-link="example-kieappk" data-test="example-kieappk" href="/k8s/ns/test-oedxx/clusterserviceversions/businessautomation-operator.7.13.1-2/app.kiegroup.org~v2~KieApp/example-kieappk">example...</a>`

jhadvig · 2023-01-21T11:34:42Z

The uninstall tests passed. ✅ The descriptor test is failing due a none related issue

jcaianirh · 2023-01-21T18:39:39Z

/retest

jcaianirh · 2023-01-23T16:40:08Z

/retest

jcaianirh · 2023-01-23T19:43:03Z

/retest

jhadvig · 2023-01-24T05:56:42Z

/retest

jhadvig · 2023-01-24T13:05:45Z

/retest

jcaianirh

/lgtm

openshift-ci · 2023-01-24T17:08:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, jhadvig, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jhadvig · 2023-01-24T17:08:25Z

/hold cancel

openshift-ci · 2023-01-24T18:52:56Z

@zherman0: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2022

openshift-ci bot requested review from spadgett and TheRealJon November 3, 2022 01:02

openshift-ci bot added component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Nov 3, 2022

zherman0 force-pushed the con3237 branch from 166f153 to 9a68b78 Compare November 3, 2022 01:04

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2022

openshift-ci bot assigned opayne1, RickJWagner and yapei Nov 3, 2022

zherman0 changed the title ~~CONSOLE-3237: Console deletes operands regardless of interdependency~~ CONSOLE-3237: Add opt out when Console deletes operands Nov 3, 2022

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 3, 2022

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 3, 2022

RickJWagner removed their assignment Nov 3, 2022

zherman0 force-pushed the con3237 branch from 078e993 to cb4116a Compare January 13, 2023 15:18

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023

Console deletes operands regardless of interdep

f166c02

zherman0 force-pushed the con3237 branch from cb4116a to f166c02 Compare January 20, 2023 22:10

openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Jan 20, 2023

jcaianirh approved these changes Jan 24, 2023

View reviewed changes

openshift-ci bot assigned jcaianirh Jan 24, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2023

openshift-merge-robot merged commit 8208836 into openshift:master Jan 24, 2023
7 checks passed

joelanford mentioned this pull request Aug 21, 2023

Support for Multiarch Manager Operator openshift/enhancements#1417

Merged

CONSOLE-3237: Add opt out when Console deletes operands #12234

CONSOLE-3237: Add opt out when Console deletes operands #12234

zherman0 commented Nov 3, 2022 •

edited

zherman0 commented Nov 3, 2022

rhamilto commented Nov 3, 2022

zherman0 commented Nov 3, 2022

opayne1 commented Nov 3, 2022

zherman0 commented Nov 3, 2022

RickJWagner commented Nov 3, 2022

zherman0 commented Nov 3, 2022

jhadvig commented Jan 3, 2023

jhadvig commented Jan 4, 2023

jcaianirh commented Jan 4, 2023

jhadvig commented Jan 5, 2023

jhadvig commented Jan 9, 2023

jhadvig commented Jan 9, 2023

zherman0 commented Jan 9, 2023

jhadvig commented Jan 10, 2023 •

edited

jcaianirh commented Jan 12, 2023

jhadvig commented Jan 16, 2023

jhadvig commented Jan 21, 2023

jcaianirh commented Jan 21, 2023

jcaianirh commented Jan 23, 2023

jcaianirh commented Jan 23, 2023

jhadvig commented Jan 24, 2023

jhadvig commented Jan 24, 2023

jcaianirh left a comment

openshift-ci bot commented Jan 24, 2023

jhadvig commented Jan 24, 2023

openshift-ci bot commented Jan 24, 2023

CONSOLE-3237: Add opt out when Console deletes operands #12234

CONSOLE-3237: Add opt out when Console deletes operands #12234

Conversation

zherman0 commented Nov 3, 2022 • edited

zherman0 commented Nov 3, 2022

rhamilto commented Nov 3, 2022

zherman0 commented Nov 3, 2022

opayne1 commented Nov 3, 2022

zherman0 commented Nov 3, 2022

RickJWagner commented Nov 3, 2022

zherman0 commented Nov 3, 2022

jhadvig commented Jan 3, 2023

jhadvig commented Jan 4, 2023

jcaianirh commented Jan 4, 2023

jhadvig commented Jan 5, 2023

jhadvig commented Jan 9, 2023

jhadvig commented Jan 9, 2023

zherman0 commented Jan 9, 2023

jhadvig commented Jan 10, 2023 • edited

jcaianirh commented Jan 12, 2023

jhadvig commented Jan 16, 2023

jhadvig commented Jan 21, 2023

jcaianirh commented Jan 21, 2023

jcaianirh commented Jan 23, 2023

jcaianirh commented Jan 23, 2023

jhadvig commented Jan 24, 2023

jhadvig commented Jan 24, 2023

jcaianirh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 24, 2023

jhadvig commented Jan 24, 2023

openshift-ci bot commented Jan 24, 2023

zherman0 commented Nov 3, 2022 •

edited

jhadvig commented Jan 10, 2023 •

edited