Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1690007: Add the ability to create labels during Deploy Image creation #1485

Merged
merged 1 commit into from Apr 26, 2019
Merged

Bug 1690007: Add the ability to create labels during Deploy Image creation #1485

merged 1 commit into from Apr 26, 2019

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 24, 2019 •
edited

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2019
@rhamilto
Copy link
Member Author

/test frontend

@rhamilto
Copy link
Member Author

/hold

Found a bug

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@rhamilto rhamilto force-pushed the deploy-image-labels branch 2 times, most recently from 058899d to 4563e6f Compare April 24, 2019 19:07
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2019
@rhamilto
Copy link
Member Author

/hold cancel

Updated to remove magic updating of default label (which was the source of the bug and a usability concern).

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
spadgett
spadgett reviewed Apr 24, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple comments on the types

frontend/public/components/deploy-image.tsx Outdated Show resolved Hide resolved
frontend/public/components/deploy-image.tsx Outdated Show resolved Hide resolved
@rhamilto rhamilto force-pushed the deploy-image-labels branch 2 times, most recently from 7326726 to 6f6728c Compare April 24, 2019 19:46
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2019
@rhamilto
Copy link
Member Author

Comments addressed. Thanks, @spadgett.

@rhamilto
Copy link
Member Author

Aligned label behavior with #1493.

spadgett
spadgett approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

@spadgett spadgett added this to the v4.2 milestone Apr 25, 2019
@spadgett
Copy link
Member

/retest

3 similar comments
@spadgett
Copy link
Member

/retest

@rhamilto
Copy link
Member Author

/retest

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 304ad1d into openshift:master-next Apr 26, 2019
@rhamilto rhamilto deleted the deploy-image-labels branch April 26, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhamilto @openshift-ci-robot @spadgett @openshift-merge-robot