Move filters and add category to OperatorHub #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
changed the title
openshift-ci-robot
added
the
size/M
alecmerdler
reviewed
May 30, 2019
spadgett
reviewed
May 30, 2019
rebeccaalpert
force-pushed
the
operatorhub-tiles
branch
from
e685274
to
f0bf521
Compare
spadgett
reviewed
May 30, 2019
rebeccaalpert
force-pushed
the
operatorhub-tiles
branch
from
ad83c6b
to
afa6005
Compare
spadgett
reviewed
May 30, 2019
rebeccaalpert
force-pushed
the
operatorhub-tiles
branch
from
afa6005
to
559047a
Compare
openshift-ci-robot
added
size/L
rebeccaalpert
force-pushed
the
operatorhub-tiles
branch
from
559047a
to
974ab5c
Compare
openshift-ci-robot
added
size/M
openshift-ci-robot
added
lgtm
|
I suspect the integration tests need to be updated |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
LGTM @rebeccaalpert! |
dtaylor113
approved these changes
May 31, 2019
|
/retest Please review the full test history for this PR and help us cut down flakes. |
spadgett
reviewed
May 31, 2019
|
/lgtm cancel Need to fix integration test failures |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
openshift-ci-robot
added
size/L
rebeccaalpert
force-pushed
the
operatorhub-tiles
branch
3 times, most recently
from
fd61b53
to
40a901e
Compare
|
lgtm, please squash |
Moved filter to the top of the screen and moved the item count to the far right. Adjusted the length of the bottom border. Added categories for capability level and added the data to the OperatorHubItem object. Fixes https://jira.coreos.com/browse/CONSOLE-1457
rebeccaalpert
force-pushed
the
operatorhub-tiles
branch
from
40a901e
to
e9356c5
Compare
|
Squashed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sg00dwin We might want to adjust the skeleton for this change. Can you take a look? |
|
@spadgett yes a small addition to account for moving the input. Probably easier to do as a follow on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the filter to the top of the screen for OperatorHub (I left Developer Catalog, which shares the same sidebar component, the same) and moved the item count to the far right.
I also added categories for capability level and added the data to the OperatorHubItem object so the filter can access it.
Fixes CONSOLE-1457.
@openshift/team-ux-review, can you please review?