Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1727772: Fix layout bugs with DownloadButton component #1957

Merged
merged 1 commit into from Jul 9, 2019

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 8, 2019

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1727772

After discussing it with @spadgett, we determined including the filename in the button isn't really necessary, can be problematic with long filenames, and we can avoid the bug entirely by removing it.

Additionally, this PR addresses a couple of other issues:

  • Error text is too big
  • Placing <DownloadButton> inside <SectionHeading> could result in an undesirable layout if error message is long. By moving <DownloadButton> below <SectionHeading>, the error message has room to grow, and the primary action is in a consistent location with list view pages. Further, this provides flexibility in where <DownloadButton> can be used because it makes no assumptions about its parent.

Before:
Button is wide, but label can be short.
csqTnagJit
Error text is too big and layout could be problematic.
8D0mhqVP53

After:
Button gets wider, but feels more natural
W27X0e0L9x
Error message is correct font size has plenty of room to grow if needed
whVhuF8n5y

@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1727772: Fix layout bugs with DownloadButton component

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2019
@alecmerdler alecmerdler removed their request for review July 9, 2019 02:57
@rhamilto
Copy link
Member Author

rhamilto commented Jul 9, 2019

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Jul 9, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a616905 into openshift:master Jul 9, 2019
@rhamilto rhamilto deleted the bz-1727772 branch July 9, 2019 17:45
@spadgett spadgett added this to the v4.2 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants