New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1727772: Fix layout bugs with DownloadButton component #1957
Conversation
@rhamilto: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1727772
After discussing it with @spadgett, we determined including the filename in the button isn't really necessary, can be problematic with long filenames, and we can avoid the bug entirely by removing it.
Additionally, this PR addresses a couple of other issues:
<DownloadButton>
inside<SectionHeading>
could result in an undesirable layout if error message is long. By moving<DownloadButton>
below<SectionHeading>
, the error message has room to grow, and the primary action is in a consistent location with list view pages. Further, this provides flexibility in where<DownloadButton>
can be used because it makes no assumptions about its parent.Before:
Button is wide, but label can be short.
Error text is too big and layout could be problematic.
After:
Button gets wider, but feels more natural
Error message is correct font size has plenty of room to grow if needed