Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1693180 - MachineSet and Machine pages need Event page for resources page consistency #2018

Merged
merged 1 commit into from Jul 17, 2019
Merged

Bug 1693180 - MachineSet and Machine pages need Event page for resources page consistency #2018

merged 1 commit into from Jul 17, 2019

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Jul 12, 2019

/assign @spadgett

The bug is referring only to Machine and MachineSet resources but other Compute resource have been missing the Events tab so adding as well.
I know this is 4.1 bug but lets add it here to the master as well and cherrypick to 4.1 branch.

PTAL

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2019
@spadgett
Copy link
Member

I would skip this cherrypick on this one. We can fix in 4.2. You can still get to the events from Home -> Events.

@spadgett
Copy link
Member

@jhadvig Can you confirm all of these resources really do generate events?

@spadgett spadgett added this to the v4.2 milestone Jul 12, 2019
@jhadvig
Copy link
Member Author

jhadvig commented Jul 12, 2019

@spadgett checked the Events page and all of those are in the picker so I assumed that they do generate events.

@spadgett
Copy link
Member

@spadgett checked the Events page and all of those are in the picker so I assumed that they do generate events.

@jhadvig The events dropdown shows all resources, not necessarily only those that we know have events. We should try to determine which ones definitely do before adding the tab.

@jhadvig
Copy link
Member Author

jhadvig commented Jul 15, 2019

@spadgett was talking to @runcom and @ingvagabund regarding MachineConfig, MachineConfigPool and MachineAutoscaler, since their controllers are located in the openshift/machine-config-operator and openshift/machine-api-operator and was told that the MachineConfig and MachineConfigPool are generating events.
With the MachineAutoscaler it's a bit more tricky since the events are generated by Cluster Autoscaler, so I would suggest to leave this resource without the Events tab.
Thoughts ?

@spadgett
Copy link
Member

@jhadvig sounds good to me

@spadgett
Copy link
Member

Looks like you accidentally checked in a .DS_Store file. (We might add that to .gitignore)

spadgett
spadgett reviewed Jul 16, 2019
View reviewed changes
frontend/public/components/machine-autoscaler.tsx Outdated
@@ -143,6 +144,7 @@ export const MachineAutoscalerDetailsPage: React.FC<MachineAutoscalerDetailsPage
pages={[
navFactory.details(MachineAutoscalerDetails),
navFactory.editYaml(),
navFactory.events(ResourceEventStream),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our discussion, let's take this out for now.

@jhadvig
Copy link
Member Author

jhadvig commented Jul 16, 2019

@spadgett PR updated. Will open a separate PR for the .DS_Store, since this is a bug fix.
PTAL

spadgett
spadgett approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @jhadvig

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

2 similar comments
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit ae907ae into openshift:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jhadvig @spadgett @openshift-ci-robot @dtaylor113 @openshift-merge-robot