New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt: VMWizard - implement footer and the wizard flow #2565
kubevirt: VMWizard - implement footer and the wizard flow #2565
Conversation
/hold |
0390676
to
857409e
Compare
269a0f7
to
aae189a
Compare
aae189a
to
8c27d00
Compare
aac86b2
to
6d13f66
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two nitpicks, not blocking
}; | ||
type CreateVMWizardFooterComponentProps = { | ||
stepData: any; | ||
createVmText: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createVmText: string; | |
createVMText: string; |
|
||
const CreateVMWizardFooterComponent: React.FC<CreateVMWizardFooterComponentProps> = ({ | ||
stepData, | ||
createVmText, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createVmText, | |
createVMText, |
/approve |
/lgtm |
- buttons, jumps
6d13f66
to
77a641f
Compare
fixed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
depends on:
implement logic (disabling, jumps) for buttons and nav list