Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: VMWizard - implement footer and the wizard flow #2565

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Sep 3, 2019

depends on:

implement logic (disabling, jumps) for buttons and nav list

@atiratree
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Sep 3, 2019
@atiratree atiratree changed the base branch from master to master-4.3 September 18, 2019 12:53
@atiratree atiratree force-pushed the kubevirt.createVMWizard.footer branch 2 times, most recently from 269a0f7 to aae189a Compare September 23, 2019 11:18
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@atiratree atiratree changed the base branch from master-4.3 to master September 26, 2019 09:28
@atiratree atiratree force-pushed the kubevirt.createVMWizard.footer branch 2 times, most recently from aac86b2 to 6d13f66 Compare September 26, 2019 15:01
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2019
@atiratree
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
Copy link
Contributor

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two nitpicks, not blocking

};
type CreateVMWizardFooterComponentProps = {
stepData: any;
createVmText: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
createVmText: string;
createVMText: string;


const CreateVMWizardFooterComponent: React.FC<CreateVMWizardFooterComponentProps> = ({
stepData,
createVmText,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
createVmText,
createVMText,

@rawagner
Copy link
Contributor

/approve

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@atiratree
Copy link
Member Author

fixed

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 300721c into openshift:master Sep 27, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants