New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pipelines to admin nav #2785
Conversation
Is the goal to only expose the
I don't know if it makes sense to create yet-another-toplevel nav item called "Pipeline" and they have the list above under it. wdyt @siamaksade ? |
@sspeiche the goal is exactly as you described. To have a a top-level nav item called "Pipeline" and list all Tekton resources like you listed. Not sure if exposing just |
OK, I'll make that update. |
We don't have details pages for a few of these resources, so they'll fall back to the generic details page for now. @siamaksade are new details pages for all the pipeline resources meant to be part of this epic? |
We probably need a more specific detail page for some of those resources. Do you have an example of the generic details page? |
I don't have a cluster running, but the generic page shows name, namespace, labels, annotations, and owner references with a YAML tab for more details. It's not hard to add a page, but would need design input. I could do something basic then update when we have designs. |
Should we just match the detail pages to the command line?
On Sun, Sep 22, 2019 at 6:45 AM Sam Padgett ***@***.***> wrote:
We probably need a more specific detail page for some of those resources.
Do you have an example of the generic details page?
I don't have a cluster running, but the generic page shows name,
namespace, labels, annotations, and owner references with a YAML tab for
more details.
It's not hard to add a page, but would need design input. I could do
something basic then update when we have designs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2785?email_source=notifications&email_token=AK4ULMR7FNDOCSYLHLGWSQTQK5ZHRA5CNFSM4IYN3B2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JGSZQ#issuecomment-533883238>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK4ULMXIYJI23VZ6ZDRYNYDQK5ZHRANCNFSM4IYN3B2A>
.
--
Ali Mobrem
OpenShift Product Management
Red Hat <https://www.redhat.com/>
amobrem@redhat.com
M: 858-882-7483
@redhat <https://twitter.com/redhat> Red Hat
<https://www.linkedin.com/company/red-hat> Red Hat
<https://www.facebook.com/RedHatInc>
<https://red.ht/sig>
|
Probably makes sense for someone on Colleen’s team to have a design story
and we keep things consistent w dev side when possible.
(that'll teach me for replying via email)
|
@serenamarie125 Agreed. @spadgett and I discussed mimicking the the devconsole for now while we work on a design. cc @bmignano @rileyhuston can you meet with @siamaksade and @alimobrem to better understand requirements? |
2cc3941
to
73c6682
Compare
Since we're waiting on details page designs, I've scoped this PR to just adding the nav items. |
@spadgett what are Pipeline Resources & Cluster Tasks? We aren't showing them on the dev side, wondering what the use cases are around those ... @siamaksade @sspeiche |
These are very low-level things and you can get to pipeline resource from pipeline mostly. Cluster Tasks will come in when developers want to build up pipelines or run tasks individually, we don't have much cases to show them yet. Does feel like something should be done with Build section as well. |
Thanks, @christianvogt PTAL |
/lgtm |
/retest |
1 similar comment
/retest |
Known OLM flake. /retest |
/retest Looks like the known flake still... |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
2 similar comments
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws-console |
/retest |
@spadgett: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I need to rebase the PR.
|
Ah yeah, it got renamed in someone's PR, I had the same rebase issue. I think it's called |
About to push an update if you can retag... |
/lgtm |
https://jira.coreos.com/browse/CONSOLE-1727
This adds a Pipelines nav item to the admin console build section. I'm opening to get input on the user experience we want. Alternately, we could create a separate nav section with all the pipeline resources.
@siamaksade @sspeiche @alimobrem @beanh66 @serenamarie125 @christianvogt thoughts?