Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipelines to admin nav #2785

Merged
merged 2 commits into from Nov 2, 2019

Conversation

spadgett
Copy link
Member

https://jira.coreos.com/browse/CONSOLE-1727

This adds a Pipelines nav item to the admin console build section. I'm opening to get input on the user experience we want. Alternately, we could create a separate nav section with all the pipeline resources.

@siamaksade @sspeiche @alimobrem @beanh66 @serenamarie125 @christianvogt thoughts?

Screen Shot 2019-09-19 at 1 12 11 PM

Screen Shot 2019-09-19 at 1 12 17 PM

@spadgett spadgett added this to the v4.3 milestone Sep 19, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console labels Sep 19, 2019
@sspeiche
Copy link

Is the goal to only expose the Pipeline resource? I would expect in the Admin side to see all resources like:

  • Pipeline
  • PipelineRun
  • PipelineResource
  • Task
  • TaskRun
  • ClusterTask

I don't know if it makes sense to create yet-another-toplevel nav item called "Pipeline" and they have the list above under it.

wdyt @siamaksade ?

@siamaksade
Copy link

@sspeiche the goal is exactly as you described. To have a a top-level nav item called "Pipeline" and list all Tekton resources like you listed.

Not sure if exposing just Pipeline resource under the Build nav item would help much.

@spadgett
Copy link
Member Author

OK, I'll make that update.

@spadgett
Copy link
Member Author

We don't have details pages for a few of these resources, so they'll fall back to the generic details page for now. @siamaksade are new details pages for all the pipeline resources meant to be part of this epic?

@siamaksade
Copy link

We probably need a more specific detail page for some of those resources. Do you have an example of the generic details page?

@spadgett
Copy link
Member Author

We probably need a more specific detail page for some of those resources. Do you have an example of the generic details page?

I don't have a cluster running, but the generic page shows name, namespace, labels, annotations, and owner references with a YAML tab for more details.

It's not hard to add a page, but would need design input. I could do something basic then update when we have designs.

@alimobrem
Copy link

alimobrem commented Sep 22, 2019 via email

@serenamarie125
Copy link
Contributor

serenamarie125 commented Sep 22, 2019 via email

@beanh66
Copy link
Member

beanh66 commented Sep 23, 2019

@serenamarie125 Agreed. @spadgett and I discussed mimicking the the devconsole for now while we work on a design. cc @bmignano @rileyhuston can you meet with @siamaksade and @alimobrem to better understand requirements?

@spadgett spadgett changed the base branch from master-4.3 to master September 26, 2019 14:36
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2019
@spadgett
Copy link
Member Author

spadgett commented Oct 1, 2019

Here's what I have currently:

Screen Shot 2019-10-01 at 9 44 43 AM

@spadgett spadgett force-pushed the pipelines branch 2 times, most recently from 2cc3941 to 73c6682 Compare October 1, 2019 14:07
@spadgett
Copy link
Member Author

spadgett commented Oct 1, 2019

Since we're waiting on details page designs, I've scoped this PR to just adding the nav items.

@spadgett spadgett changed the title [WIP] Add Pipelines to admin nav Add Pipelines to admin nav Oct 1, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2019
@serenamarie125
Copy link
Contributor

@spadgett what are Pipeline Resources & Cluster Tasks? We aren't showing them on the dev side, wondering what the use cases are around those ... @siamaksade @sspeiche

@sspeiche
Copy link

sspeiche commented Oct 1, 2019

@spadgett what are Pipeline Resources & Cluster Tasks? We aren't showing them on the dev side, wondering what the use cases are around those ... @siamaksade @sspeiche

These are very low-level things and you can get to pipeline resource from pipeline mostly. Cluster Tasks will come in when developers want to build up pipelines or run tasks individually, we don't have much cases to show them yet.

Does feel like something should be done with Build section as well.

@spadgett
Copy link
Member Author

Thanks, @christianvogt PTAL

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@andrewballantyne
Copy link
Contributor

/retest

1 similar comment
@andrewballantyne
Copy link
Contributor

/retest

@spadgett
Copy link
Member Author

Known OLM flake.

/retest

@andrewballantyne
Copy link
Contributor

/retest

Looks like the known flake still...

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2019

/retest

2 similar comments
@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor

/test e2e-aws-console
/test e2e-gcp-console

@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 1, 2019

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console 73c6682 link /test e2e-aws-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2019

I need to rebase the PR.

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(200,19): Cannot find name 'SHOW_PIPELINE'.

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(212,19): Cannot find name 'SHOW_PIPELINE'.

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(224,19): Cannot find name 'SHOW_PIPELINE'.

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(236,19): Cannot find name 'SHOW_PIPELINE'.

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(248,19): Cannot find name 'SHOW_PIPELINE'.

ERROR in /go/src/github.com/openshift/console/frontend/packages/dev-console/src/plugin.tsx
(260,19): Cannot find name 'SHOW_PIPELINE'.

@andrewballantyne
Copy link
Contributor

Ah yeah, it got renamed in someone's PR, I had the same rebase issue. I think it's called FLAG_OPENSHIFT_PIPELINE in the const.ts file for dev-console.

@spadgett

@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2019

About to push an update if you can retag...

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@andrewballantyne
Copy link
Contributor

/lgtm

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit b7a5d40 into openshift:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet