Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text to ConsoleCLIDownload YAML template #2888

Merged
merged 1 commit into from Oct 3, 2019

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 2, 2019

This fixes the merge queue until we can change the CRD validation. I think it's probably better to have the text property in the example anyway so users know they can change it.

/assign @rhamilto @benjaminapetersen

@spadgett spadgett added this to the v4.3 milestone Oct 2, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Oct 2, 2019
@rhamilto
Copy link
Member

rhamilto commented Oct 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2019

I missed a reference in the test scenario. Updated now.

@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2019

/retest

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Oct 3, 2019

/retest

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019
@spadgett
Copy link
Member Author

spadgett commented Oct 3, 2019

Retagging to unblock the queue

@openshift-merge-robot openshift-merge-robot merged commit e308043 into openshift:master Oct 3, 2019
@spadgett spadgett deleted the fix-queue branch May 1, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants