Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total values to utilization card #3166

Merged

Conversation

rawagner
Copy link
Contributor

utilization_max

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Oct 31, 2019
@vojtechszocs
Copy link
Contributor

/retest

/** The utilization item title */
title: string;
/** The utilization item to be replaced */
id: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should also write an extension check that ensures plugins don't re-replace dashboard utilization items.

Can be done as a follow-up.

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@rawagner
Copy link
Contributor Author

rawagner commented Nov 1, 2019

/retest

2 similar comments
@rawagner
Copy link
Contributor Author

rawagner commented Nov 1, 2019

/retest

@rawagner
Copy link
Contributor Author

rawagner commented Nov 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 57cffa5 into openshift:master Nov 1, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants