Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace label selector to namespace dashboard links #3176

Merged

Conversation

spadgett
Copy link
Member

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dashboard Related to dashboard size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2019
return true;
}

// Show the link if either namespaces or the selector matches this namespace.
Copy link
Member

@rhamilto rhamilto Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is incorrect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's right? We show the link if we match either namespaces OR selector. (Maybe I should rephrase.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is correct but does not reflect the code change, but overall logic.
Check https://github.com/openshift/api/blob/master/console/v1/types_console_link.go#L48

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the API doc saying the same thing?

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

return true;
}

// Show the link if either namespaces or the selector matches this namespace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is correct but does not reflect the code change, but overall logic.
Check https://github.com/openshift/api/blob/master/console/v1/types_console_link.go#L48

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

/retest

@spadgett spadgett added this to the v4.3 milestone Oct 31, 2019
@spadgett
Copy link
Member Author

/retest

1 similar comment
@jhadvig
Copy link
Member

jhadvig commented Oct 31, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9a20683 into openshift:master Nov 1, 2019
@spadgett spadgett deleted the namespace-link-selector branch November 1, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants