New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace label selector to namespace dashboard links #3176
Add namespace label selector to namespace dashboard links #3176
Conversation
1c8785e
to
9cea406
Compare
return true; | ||
} | ||
|
||
// Show the link if either namespaces or the selector matches this namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's right? We show the link if we match either namespaces OR selector. (Maybe I should rephrase.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is correct but does not reflect the code change, but overall logic.
Check https://github.com/openshift/api/blob/master/console/v1/types_console_link.go#L48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the API doc saying the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
return true; | ||
} | ||
|
||
// Show the link if either namespaces or the selector matches this namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is correct but does not reflect the code change, but overall logic.
Check https://github.com/openshift/api/blob/master/console/v1/types_console_link.go#L48
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
1 similar comment
/retest |
https://jira.coreos.com/browse/CONSOLE-1828
/assign @rhamilto
/cc @jhadvig