New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt: split VMI selectors #3191
kubevirt: split VMI selectors #3191
Conversation
Hot fix to enable integration tests. This change does not break other flows, just enables to import simplier modules to by-pass immediate execution of code in more complex ones.
@mareklibra with this change integration-tests can be executed with |
Unit tests (Jest) use Integration tests (Protractor) interact with Chrome browser instance and AFAIK don't use
Jest is configured (via |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mareklibra, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hot fix to enable integration tests #3189.
When importing from
kubevirt-plugin/src/selectors/vmi/selectors.ts
in an integrationtest, the tests are failing on unrelated errors (i.e. from CSS loader).
There is suspicion that the issue is related to node.js environment where
window
object is missing but
@console/internal
modules are requesting it without functionwrapper (i.e. k8s.ts and
k8sBasePath
). I will further investigate.This change does not break other flows, just enables to import simplier
modules to by-pass immediate execution of code in more complex ones.