New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add list view to topology #3199
add list view to topology #3199
Conversation
4d35c3a
to
1a38fa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const application = activeApplication === ALL_APPLICATIONS_KEY ? undefined : activeApplication; | ||
const showListView = matchPath(match.path, { | ||
path: '*/list', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels weird that this exists in this state. But I suppose it's code inside a component, so it's not like it can bleed to the rest of the app. It can only handle situations where it is mounted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's like using a nested route. But since we need to do more than just render a component, I used matchPath
which uses the same logic as route.
Yes that view is not the same as the topology. To keep things simple I render the overview component as is. |
/test e2e-gcp-console |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-console |
Fixes: https://jira.coreos.com/browse/ODC-2038
Reuses the existing
Overview
component and renders it in place of the topology when visiting the topology url with the suffix/list
.