Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list view to topology #3199

Merged
merged 1 commit into from Nov 3, 2019

Conversation

christianvogt
Copy link
Contributor

Fixes: https://jira.coreos.com/browse/ODC-2038

Reuses the existing Overview component and renders it in place of the topology when visiting the topology url with the suffix /list.

listview

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2019
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Only "issue" is this showing up when you're on list page and have no workloads in the project. It's not the end of the world because it gives you full access to adding too.

image

const application = activeApplication === ALL_APPLICATIONS_KEY ? undefined : activeApplication;
const showListView = matchPath(match.path, {
path: '*/list',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels weird that this exists in this state. But I suppose it's code inside a component, so it's not like it can bleed to the rest of the app. It can only handle situations where it is mounted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's like using a nested route. But since we need to do more than just render a component, I used matchPath which uses the same logic as route.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2019
@christianvogt
Copy link
Contributor Author

Yes that view is not the same as the topology. To keep things simple I render the overview component as is.
The only other way to display the same empty state page as the topology would be to update the overview or to share the exact same data so we can fetch upfront.

@christianvogt
Copy link
Contributor Author

/test e2e-gcp-console

@rohitkrai03
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit 6202afe into openshift:master Nov 3, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 4, 2019
@christianvogt christianvogt deleted the list-view branch August 20, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants