New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the HyperConverged model for network attachment definitions form #3202
Fix the HyperConverged model for network attachment definitions form #3202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5761850
to
78dc204
Compare
kind: 'hyperconverged', | ||
plural: 'hyperconvergeds', | ||
namespaced: true, | ||
abbr: 'hco', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in uppercase
abbr: 'hco', | |
abbr: 'HCO', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the abbreviation for kubectl
/oc
, so you can call oc get hco
instead of oc get hyperconverged
. It should remain lower-case, following the CRD https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/deploy/crds/hco.crd.yaml#L18. Please correct me if I'm wrong and this is some UI abbreviation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are UI abbreviations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
78dc204
to
b99ce12
Compare
/lgtm |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, phoracek, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This PR corrects mistakes in the HyperConverged model used for the network attachment definitions form.
@phoracek