Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the HyperConverged model for network attachment definitions form #3202

Merged

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Nov 3, 2019

This PR corrects mistakes in the HyperConverged model used for the network attachment definitions form.

@phoracek

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2019
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind: 'hyperconverged',
plural: 'hyperconvergeds',
namespaced: true,
abbr: 'hco',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in uppercase

Suggested change
abbr: 'hco',
abbr: 'HCO',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the abbreviation for kubectl/oc, so you can call oc get hco instead of oc get hyperconverged. It should remain lower-case, following the CRD https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/deploy/crds/hco.crd.yaml#L18. Please correct me if I'm wrong and this is some UI abbreviation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are UI abbreviations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@rawagner
Copy link
Contributor

/lgtm

@pcbailey
Copy link
Contributor Author

/retest

1 similar comment
@mareklibra
Copy link
Contributor

/retest

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, phoracek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pcbailey
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 17be172 into openshift:master Nov 13, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 19, 2019
@pcbailey pcbailey deleted the fix-hyperconverged-model branch October 26, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants