Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1768611: Fix Kebab visibility on VMPage #3238

Merged
merged 1 commit into from Nov 10, 2019
Merged

Bug 1768611: Fix Kebab visibility on VMPage #3238

merged 1 commit into from Nov 10, 2019

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Nov 5, 2019

The scroller prevents kebab menu to be fully visible
for the user when opened on the last row in the VMList.

The issue is fixed by adding extra space (padding-bottom) so
the scroller can take the full height into consideration.

The issue can be observed in FF (not Chrome).

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1768611 (includes video)


Other ideas considered when fixing (more complex compared to recent fix):

  • fix computation around WindowScroller
  • add the padding-bottom just in case the Kebab is open

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 5, 2019
@openshift-ci-robot
Copy link
Contributor

@mareklibra: This pull request references Bugzilla bug 1768611, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1768611: Fix Kebab visibility on VMPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2019
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@openshift-ci-robot
Copy link
Contributor

@mareklibra: This pull request references Bugzilla bug 1768611, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1768611: Fix Kebab visibility on VMPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@mareklibra: This pull request references Bugzilla bug 1768611, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1768611: Fix Kebab visibility on VMPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2019
@mareklibra
Copy link
Contributor Author

Cc @christianvogt - same issue can be observed on the pod page as well.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 5, 2019
@openshift-ci-robot
Copy link
Contributor

@mareklibra: This pull request references Bugzilla bug 1768611, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1768611: Fix Kebab visibility on VMPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@mareklibra: This pull request references Bugzilla bug 1768611, which is valid.

In response to this:

Bug 1768611: Fix Kebab visibility on VMPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The scroller prevents kebab menu to be fully visible
for the user when opened on the last row in the VMList.

The issue is fixed by adding extra space (padding-bottom) so
the scroller can take the full height into consideration.

The issue can be observed in FF (not Chrome).
@mareklibra
Copy link
Contributor Author

/retest

1 similar comment
@mareklibra
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor

rawagner commented Nov 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Nov 9, 2019

/retest

@spadgett spadgett added this to the v4.3 milestone Nov 9, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit da80144 into openshift:master Nov 10, 2019
@openshift-ci-robot
Copy link
Contributor

@mareklibra: All pull requests linked via external trackers have merged. Bugzilla bug 1768611 has been moved to the MODIFIED state.

In response to this:

Bug 1768611: Fix Kebab visibility on VMPage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants