New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1768614: Fix add disk modal #3337
Bug 1768614: Fix add disk modal #3337
Conversation
After a disk has been added to a VM its type and interface are now passed to the VM's yaml. Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
NOTE: the PR : #3237 will change the code again. |
@@ -25,7 +25,7 @@ export class DiskWrapper extends ObjectWithTypePropertyWrapper<V1Disk, DiskType> | |||
}, | |||
{ | |||
initializeWithType: type, | |||
initializeWithTypeData: type === DiskType.DISK && bus ? { bus: bus.getValue() } : undefined, | |||
initializeWithTypeData: bus ? { bus: bus.getValue() } : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should rather say the following, because the bus is defined for everything except floppies
initializeWithTypeData: bus ? { bus: bus.getValue() } : undefined, | |
initializeWithTypeData: type !== DiskType.FLOPPY && bus ? { bus: bus.getValue() } : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suomiy Floppies are deprecated no?
https://kubevirt.io/user-guide/docs/latest/creating-virtual-machines/disks-and-volumes.html#floppy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, thanks
/lgtm |
/approve |
/joke |
@suomiy: Why are pirates called pirates? Because they arrr! In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
is my |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irosenzw, jelkosz, rawagner, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@irosenzw: All pull requests linked via external trackers have merged. Bugzilla bug 1768614 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After a disk has been added to a VM
its type and interface are now passed to the VM's yaml.
Signed-off-by: Ido Rosenzwig irosenzw@redhat.com