New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create watch k8s hook #3443
Create watch k8s hook #3443
Conversation
/hold |
7abc858
to
71d3e09
Compare
71d3e09
to
fc26d5e
Compare
/hold cancel |
9dca8c9
to
a494421
Compare
@spadgett I'd like to get your feedback on this one |
a494421
to
ee7318a
Compare
/assign @spadgett @benjaminapetersen |
ee7318a
to
e8b74a4
Compare
rebased and renamed note that I converted just a few cards to use this hook as example, we can use the hook for all cards once approved |
The recent change should fix remaining type related issues. /lgtm |
Need to retain -<DashboardCard>
+<DashboardCard data-test-id="inventory-card"> |
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
240b8dd
to
de9c482
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
This hook is intended to be used in functional components as alternative to wrapping them in
Firehose
.I've created two versions