New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the Pipeline Logs streaming issue #3504
Fixes the Pipeline Logs streaming issue #3504
Conversation
const containerNames = containers.map((c) => c.name); | ||
const sortedContainerStatus = []; | ||
containerStatus.forEach((cs) => { | ||
const containerIndex = containerNames.indexOf(cs.name); | ||
sortedContainerStatus[containerIndex] = cs; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more or less the new code - everything else is just de-duplication of logic.
Ahh, so the issue is around the container and the status array which doesn't follow order. Good catch. |
Title of the PR has been updated to bring this out of WIP. Please review this PR in the context of "fixing the streaming of logs" and note the issues at the bottom of the description that will be dealt with in other PRs. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
https://jira.coreos.com/browse/ODC-1849
https://jira.coreos.com/browse/ODC-1804
Fixes the streaming issue of Pipeline Logs. There was a misunderstanding that the
container statuses
and thecontainer specs
were two arrays that were in parallel, that doesn't seem to be the case. The issue we saw in the UI was it was rendering the first container based off of another container (in this case, the build container) which took much longer to complete. Looked like the logs stalled, but it was just not rendering the containers properly.Fix the scrolling issuethe logs do not anchor to the bottom, so now that the logs properly stream they don't actually make it easy to see all the live results as they happenCapture a gif of the logs streaming AND scrollingAfter talking with @christianvogt, the issues of logs being capped at 1k lines and the scrolling issue has been put into separate bugs. The streaming of logs works again via this PR, so it'll serve as a foundation as we discuss what else is to be fixed for 4.3.
Related Issues:
cc @abhinandan13jan @christianvogt